Linked List Implementation error in C

Question

First of all sorry if my question is a little bit silly but it is really important to learn from these stupid mistakes specially when I'm learning something new like Linked List in C programming language which is why I'm here, I'm implementing a simple linked list using a seperate function that insert a node(element) in the start of list but This problem always happens, I'll show you the code and tell me if I'm doing something wrong and thanx alot:

#include <stdio.h>
#include <stdlib.h>

typedef struct element{
    int nb;
    struct element *next;
}e;
e Insert(e hd,int x){
    e *temp = (e*)malloc(sizeof(e));
    temp->nb=x;
    temp->next = hd; /*It shows that the error is here, all what im doing here is that im letting the temp element points to whichever the head elements in pointing at so it can take it place as the first element)*/
    return temp; /*here I'm returning the @ of temp to the head node*/
}
int main(int argc, char *argv[]) {
    e *head=NULL;
    head=Insert(head,5);
    system("PAUSE");    
    return 0;
}

and what the error says is : incompatible types in assignment

Don't you get a warning, calling Insert(e, int) as Insert(e*,int)? (head is an e *)? — Paul Roub
– Paul Roub, Commented May 15, 2015 at 17:56
Also your Insert() method returns an e *, not an e as you declared. — ericbn
– ericbn, Commented May 15, 2015 at 17:57

Havenard · Accepted Answer · 2015-05-15 19:03:41Z

3

Insert() should pass e* in and returns e*.

e* Insert(e* hd,int x){
    e *temp = malloc(sizeof(e));
    temp->nb=x;
    temp->next = hd;
    return temp;
}

edited May 15, 2015 at 19:03

Havenard

28.1k5 gold badges38 silver badges66 bronze badges

answered May 15, 2015 at 17:55

timrau

23.1k4 gold badges55 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

shruti1810 · Accepted Answer · 2015-05-15 18:03:57Z

0

Insert should be taking e* hd as argument and returning e*. The method should be:

e* Insert(e* hd,int x){...}

answered May 15, 2015 at 18:03

shruti1810

4,0452 gold badges18 silver badges28 bronze badges

Collectives™ on Stack Overflow

Linked List Implementation error in C

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related