Java String doesn't get replaced

Question

I have made this small script to test something, but I can't get it working. I want it to replace the "%20" in the string to " ". This gets printed out: Ravenous%20Cache.zip

package test;

public class Test {

    public static void main(String[] args) {
        System.out.println(getArchivedName());
    }

    private static String cacheLink = "https://dl.dropboxusercontent.com/u/Ravenous%20Cache.zip";

    private static String getCacheLink() {
        return cacheLink;
    }

    private static String getArchivedName() {
        String name = cacheLink.replace("%20", " ");
        int lastSlashIndex = name.lastIndexOf('/');
        if (lastSlashIndex >= 0 
            && lastSlashIndex < getCacheLink().length() -1) { 
            return getCacheLink().substring(lastSlashIndex + 1);
        } else {
            System.err.println("Error Downloading Game Files.");
        }
        return "";
    }

}

That's because you are returning a substring of getCacheLink() instead of a substring of name. — RealSkeptic
– RealSkeptic, Commented May 28, 2015 at 16:11
Works just fine. As RealSkeptic said you are returning the value before it was replaced not after. — basic
– basic, Commented May 28, 2015 at 16:14

JP Moresmau · Accepted Answer · 2015-05-28 16:11:48Z

2

You're calling getCacheLink() again when you take the substring that gives you back the original string

return name.substring(lastSlashIndex + 1);

answered May 28, 2015 at 16:11

JP Moresmau

7,42319 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

RuuddR Over a year ago

Thank you, this works. Everyone thanks for your posts and I'm sure that you're all right.

Forseth11 · Accepted Answer · 2015-05-28 16:12:15Z

Try this:

public static void main(String[] args) {
        System.out.println(getArchivedName());
    }

    private static String cacheLink = "https://dl.dropboxusercontent.com/u/Ravenous%20Cache.zip";

    private static String getCacheLink() {
        return cacheLink;
    }

    private static String getArchivedName() {
        String name = cacheLink.replace("%20", " ");
        int lastSlashIndex = name.lastIndexOf('/');
        if (lastSlashIndex >= 0 
            && lastSlashIndex < getCacheLink().length() -1) { 
            return name.substring(lastSlashIndex + 1);//Changed
        } else {
            System.err.println("Error Downloading Game Files.");
        }
        return "";
    }

You were returning getCacheLink() not name.

Rajesh · Accepted Answer · 2015-05-28 16:12:59Z

0

public class Test {

    public static void main(String[] args) {
        System.out.println(getArchivedName());
    }

    private static String cacheLink = "https://dl.dropboxusercontent.com/u/Ravenous%20Cache.zip";

    private static String getCacheLink() {
        return cacheLink;
    }

    private static String getArchivedName() {
        cacheLink = cacheLink.replace("%20", " ");
        int lastSlashIndex = cacheLink.lastIndexOf('/');
        if (lastSlashIndex >= 0 && lastSlashIndex < getCacheLink().length() - 1) {
            return getCacheLink().substring(lastSlashIndex + 1);
        } else {
            System.err.println("Error Downloading Game Files.");
        }
        return "";
    }
}

answered May 28, 2015 at 16:12

Rajesh

2,1551 gold badge14 silver badges14 bronze badges

1 Comment

Rajesh Over a year ago

Ravenous Cache.zip is what you get after running this.

Collectives™ on Stack Overflow

Java String doesn't get replaced

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related