Bash script not running in Ubuntu

Question

I'm getting started with bash scripting and made this little script following along a short guide but for some reason when I run the script with sh myscript I get

myscript: 5: myscript: 0: not found running on ubuntu 12.04

here is my script below I should at least see the echo message if no args are set:

#!/bin/bash
#will do something

name=$1
username=$2
if (( $# == 0 ))
then
    echo "##############################"
    echo "myscript [arg1] [arg2]"
    echo "arg1 is your name"
    echo "and arg2 is your username"
fi

var1="Your name is ${name} and your username is ${username}"

`echo ${var1} > yourname.txt`

chepner · Accepted Answer · 2015-07-03 15:18:21Z

4

`echo ${var1} > yourname.txt`

Get rid of the backticks.

echo ${var1} > yourname.txt

...for some reason when I run the script with sh myscript...

Don't run it that way. Make the script executable and run it directly

chmod +x myscript
./script

(or run with bash myscript explicitly).

edited Jul 3, 2015 at 15:18

chepner

538k77 gold badges594 silver badges746 bronze badges

answered Jul 3, 2015 at 14:57

John Kugelman

364k70 gold badges555 silver badges600 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Etan Reisner Over a year ago

The problem with the backticks is that they run the command and then the shell tries to run the output from that command as a command again. And sh is not bash. You should always use what you mean.

azo_blnt Over a year ago

Thank you that works, as long as I run with ./ in front but if I just call it with myscript I get command not found but I can figure that out.

Etan Reisner Over a year ago

@A.Bal Without a path (and ./ is a path) the shell does a $PATH lookup for the name myscript and can't find it. If you want that to work you need to put it in a directory in your $PATH (or add a directory to your $PATH and put it in there).

Cody Stevens · Accepted Answer · 2015-07-03 15:11:07Z

1

It looks like that expression will work in bash but not in sh. As others pointed out change it to executable, make sure your shebang line is using bash and run it like this:

./myscript

If you want to run it with sh then it is complaining about line 5. Change it to this and it will work in /bin/sh.

if [ $# -ne 0 ]

Check out the man page for test.

Also you don't need the backticks on this line: echo ${var1} > yourname.txt

edited Jul 3, 2015 at 15:11

answered Jul 3, 2015 at 15:02

Cody Stevens

4144 silver badges9 bronze badges

7 Comments

Etan Reisner Over a year ago

(( $# == 0 )) is perfectly valid shell test (try it). It is an arithmetic expression.

Cody Stevens Over a year ago

Yeah.. I tried it on the command line and it does work. I was able to replicate his error and I knew the other expression would work. Which is why I said I thought that was going on. I'd love to know what is happening there for myself as well.

Cody Stevens Over a year ago

Ok.. I see what's happening. That error only occurs if you run it with the /bin/sh shell. Running it with bash it works perfectly. Updating my answer to reflect that.

Etan Reisner Over a year ago

Right, sh is not bash.

fedorqui Over a year ago

But seems to be what OP is doing: "when I run the script with sh myscript"

|

Collectives™ on Stack Overflow

Bash script not running in Ubuntu

2 Answers 2

3 Comments

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related