c: invert string using recursion?

Question

What is wrong in this function?

   void stringReverse (char stringa[])
    {
        if (stringa[0]!='\0')
        {
            return stringReverse(&stringa[1]);
            printf("%c", stringa[0]);
        }
    }

I have to write a function that invert a string (ex: "Hello" in "olleH") using recursion; the function has to receive a string (nothing else) and to print the character in the inverse order... i don't understand why what i write didn't print anything...

Look at those few lines: Will the printf() ever be reached? — alk
– alk, Commented Jul 9, 2015 at 13:21
Please avoid using tags in titles, i.e, don't prefix c questions with "c:" in the title. — Spikatrix
– Spikatrix, Commented Jul 11, 2015 at 8:02

Matt Lacey · Accepted Answer · 2015-07-09 13:14:26Z

2

return returns a value from the function and performs no further statements in that scope. Have a think about where you want that statement to be...

Not answering in full because this sounds like homework!

answered Jul 9, 2015 at 13:14

Matt Lacey

8,27539 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

AndyG Over a year ago

This should be a comment

Matt Lacey Over a year ago

I was inlclined to make it a comment, but I also think different treatment is neccessary for homework answers. Better for people to think that to just be told in those circumstances.

StackUser Over a year ago

Thanks, I appreciated the fact that you didn't solve my problem but you make me think over the error I committed, that's is definitely better!

stuck · Accepted Answer · 2015-07-09 13:17:51Z

1

Just do not use return. Use stringReverse(&stringa[1]); instead of return stringReverse(&stringa[1]);

Because, the 'return' statement is using for return a value. But your function is void type, that means it returns nothing, it doesn't need.

answered Jul 9, 2015 at 13:17

stuck

1,5982 gold badges19 silver badges34 bronze badges

Collectives™ on Stack Overflow

c: invert string using recursion?

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related