AngularJS : Using factory inside a controller

Question

This is my first attempt to use the Angularjs and I'm trying to create a service and use it inside a controller:

var appTest = angular.module("appTest", ["ngRoute"]);
var appTestControllers = angular.module('appTestControllers', []);

appTest.config(['$routeProvider', '$locationProvider',
    function($routeProvider, $locationProvider) {

        $routeProvider.
            when('/', {
                templateUrl: 'partials/home.html',
                controller: 'HomeCtrl'
            });

            $locationProvider.html5Mode(false);
    }
]);

appTest.factory("booksApi", function($http){

    var _getBooks = function() {
        return $http.get('http://localhost/editora-voo/website/books.json');
    };

    return{
        getBooks: _getBooks
    };

});


appTest.controller('HomeCtrl', ['$scope', '$http', function($scope, $http, booksApi) {

    booksApi.getBooks().success(function(data) {
        $scope.books = data;
    });
}]);

But it is returning an error: Cannot read property 'getBooks' of undefined

Pankaj Parkar · Accepted Answer · 2018-03-07 11:39:03Z

4

You missed to add booksApi depnedency inside your controller dependency array, You should add it first and then use that inside the function of controller.

Controller

appTest.controller('HomeCtrl', ['$scope', '$http', 'booksApi', //<--missed dependency here
  function($scope, $http, booksApi) {
    booksApi.getBooks().then(function(response) {
        $scope.books = response.data;
    });
}]);

Plunkr Here

edited Mar 7, 2018 at 11:39

answered Jul 12, 2015 at 20:26

Pankaj Parkar

136k23 gold badges241 silver badges307 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

marcelo2605 Over a year ago

Thanks for the answer. But now appear this error: Error: $injector:unpr Unknown Provider

Pankaj Parkar Over a year ago

@marcelo2605 did you change your controller code as I suggested..? could you paste whole console error here

marcelo2605 Over a year ago

Yes. Here is the error: Error: [$injector:unpr] errors.angularjs.org/1.4.1/$injector/…

Pankaj Parkar Over a year ago

@marcelo2605 you should also remove . from

$routeProvider.             when('/', {                 templateUrl: 'partials/home.html',                 controller: 'HomeCtrl'             }).

which is placed at the end

marcelo2605 Over a year ago

I remove the other conditions and forgot to remove ".". This is not the problem.

|

Collectives™ on Stack Overflow

AngularJS : Using factory inside a controller

1 Answer 1

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related