Storing HTML into a javascript variable

Question

I'm having some trouble with some javascript. I'm using jQuery to dynamiclly add rows to a table. Additionally the javascript is being generated from some PHP and Kohana code.

Here is the script.

<script type="text/javascript">   
    function delExtensionNumber(element){
        $(element).prev().attr('value', 'X'); 
        $(element).parent().parent().hide();
    }

    function addExtensionNumber(){
        lines = <?php echo form::dropdown($ext_id."[did]", $lines, ''); ?>;
        extensions = <?php echo form::dropdown($ext_id."[extension]", $phones, ''); ?>;

        $('#line-extensions > tbody:last').append('<tr><td>'+lines+'</td><td>'+extensions+'</td><td><input type="hidden" name="'+<?php echo $ext_id;?>+'[state]" value="0" /><a class="hide" onclick="delExtensionNumber(this)"></a></td></tr>');

        <?php $ext_id++; ?>
    }
</script>

This works fine in Firefox. But in IE and Chrome it doesn't work. Nothing happens in google Chrome. In IE I get an error on the page. The error is a syntax error. It doesn't like the < character after the word line.

Ok, so I thought I better put some quotes around this string. But... when I do that nothing works.

Could you show what is outputted in the firefox version?

Duniyadnd
– Duniyadnd

2010-07-05 01:00:47 +00:00
Commented Jul 5, 2010 at 1:00 — Duniyadnd
– Duniyadnd, Commented Jul 5, 2010 at 1:00

icktoofay · Accepted Answer · 2010-07-05 01:13:07Z

5

I'm just going to assume that form::dropdown is spitting out plain HTML. In Firefox, this is being interpreted with E4X, and then turned back into a string when concatenated. IE and Chrome do not support E4X. To make it work, you could do something like this:

lines = <?php echo json_encode(form::dropdown(...)); ?>;

Edit: The reason it's not working when you're putting quotes around it is because the HTML contains quotes. The code above will escape the quotes correctly.

edited Jul 5, 2010 at 1:13

answered Jul 5, 2010 at 1:06

icktoofay

130k23 gold badges261 silver badges239 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

alex Over a year ago

You are correct, form::dropdown() does return a string of HTML.

hookenz Over a year ago

Frantastic. Not what I would have thought of but that worked great! thanks alot.

hookenz Over a year ago

Actually I was pretty careful with the quotes but i still couldn't make it work. So the json encode version did the job.

mykhal · Accepted Answer · 2010-07-05 01:04:42Z

2

Chrome does not support XML literal syntax, you can't write e.g. line = <div>foo</div>, you have to enclose the data into a string.

lines = '<?php echo form::dropdown($ext_id."[did]", $lines, ""); ?>;'

could work (and you should possibly also escape ')

answered Jul 5, 2010 at 1:04

mykhal

20.1k11 gold badges84 silver badges84 bronze badges

1 Comment

hookenz Over a year ago

That's what I thought might work, but actually it doesn't work at all.

Germán Rodríguez · Accepted Answer · 2010-07-05 01:14:45Z

-2

I strongly recommend you to use Jquery DOM Creation Plugin

Easy DOM creation for jQuery

it would be a lot, easier.

answered Jul 5, 2010 at 1:14

Germán Rodríguez

4,2881 gold badge21 silver badges19 bronze badges

2 Comments

icktoofay Over a year ago

I don't see why. The HTML is generated by Kohana, and so I don't see why it would be necessary to imitate that function client-side. For all I know, it might rely on something from the database, and would be impossible to implement client-side.

Germán Rodríguez Over a year ago

i misunderstood your question.

Collectives™ on Stack Overflow

Storing HTML into a javascript variable

3 Answers 3

3 Comments

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related