Create an array of ids with rails

Question

I am trying to create an array of ids so that I can query if a certain id is associated with an object. Here is my method but it isnt adding id's to the array.

class Report
  include Mongoid::Document

  has_and_belongs_to_many :reportapprovals, class_name: "Reportapproval", inverse_of: :report

  def bind_reportapproval
    @reportapprovals = Reportapproval.where(tenant_id: self.tenant_id).all

    if @reportapprovals.present? && @reportapprovals.any? { |ra| ra.tenant_approved == true }
      @reportapprovals.each do |ra|
        self.reportapproval_ids = ra.id
      end
    end
  end
end

This is suppose to add an array of reportapproval_ids to the report object.

Well, you set the value to each id then continually overwrite it. — Dave Newton
– Dave Newton, Commented Aug 14, 2015 at 0:52
ok, how do i fix that add them to an array with <<? Also when I look at it in console there are NO id's? — SupremeA
– SupremeA, Commented Aug 14, 2015 at 0:53
In the if statement you've got this: @reportapprovals.any? { |tenant_approved| tenant_approved == true} which is going to iterate through each reportapproval and check if it is equal to true, but it won't ever be since it will be an instance of a Mongoid record. Did you maybe mean something like this? @reportapprovals.any? { |ra| ra.tenant_approved == true} — neuronaut
– neuronaut, Commented Aug 14, 2015 at 0:54

lurker · Accepted Answer · 2015-08-14 01:00:02Z

1

Rails actually has a method for that:

if @reportapprovals.present? && @reportapprovals.any? { |tenant_approved| tenant_approved }
  self.reportapproval_ids = @reportapprovals.ids
end

answered Aug 14, 2015 at 1:00

lurker

58.5k9 gold badges74 silver badges108 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

lurker · Accepted Answer · 2015-08-14 01:01:22Z

1

You're setting the value of the array equal to ONE ID. Try this:

if true # use correct conditional statement
  self.reportapproval_ids = @reportapprovals.pluck(:id)
end

edited Aug 14, 2015 at 1:01

lurker

58.5k9 gold badges74 silver badges108 bronze badges

answered Aug 14, 2015 at 0:54

kjmagic13

1,3288 silver badges15 bronze badges

1 Comment

SupremeA Over a year ago

Thanks I appreciate the answer but the other is cleaner.

Collectives™ on Stack Overflow

Create an array of ids with rails

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related