Java string.format() only half working

Question

I am trying to construct a string using string.format(), but it stops working (just over) half way through.

private String constructMessage(String messageType, int messageCode,Position location) {
    double lat = location.getLat();
    double lon = location.getLon();
    double ele = location.getEle();
    double speed = 0.0;
    double heading = 0.0;

    String msg = "$PNGVEST," + messageType + "," + VEST_ID + ","
            + System.currentTimeMillis() + "," + lat + "," + lon + "," + ele
            + "," + speed + "," + heading + "," + messageCode;

    String test = String.format("$PNGVEST,%s,%d,%d,%f,%f,%f,$f,$f,$d",
            messageType, VEST_ID, System.currentTimeMillis(), lat, lon, ele,
            speed, heading, messageCode);

    System.out.println(msg);
    System.out.println(test);
    return msg;
}

When I run the above code, I get the following output:

$PNGVEST,LOCATION,1,1439998967553,51.558641765246364,-3.043043462354341,-1.0,0.0,0.0,0
$PNGVEST,LOCATION,1,1439998967553,51.558642,-3.043043,-1.000000,$f,$f,$d
$PNGVEST,LOCATION,1,1439998968553,51.55862560874394,-3.043027770590568,-1.0,0.0,0.0,0
$PNGVEST,LOCATION,1,1439998968553,51.558626,-3.043028,-1.000000,$f,$f,$d

Why does it not format the last 3 variables?

KeV · Accepted Answer · 2015-08-19 16:19:48Z

4

You made typo's with your last 3 variables. You noted $f and $d instead of %f and %d.

It should be :

String test = String.format("$PNGVEST,%s,%d,%d,%f,%f,%f,%f,%f,%d",
        messageType, VEST_ID, System.currentTimeMillis(), lat, lon, ele,
        speed, heading, messageCode);

Instead of

String.format("$PNGVEST,%s,%d,%d,%f,%f,%f,$f,$f,$d", ...);

edited Aug 19, 2015 at 16:19

answered Aug 19, 2015 at 16:13

KeV

2,8833 gold badges23 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

rj93 Over a year ago

What a fresh set of eyes can do. It even took me about a minute to notice what you had even changed.

KeV Over a year ago

Such typo's are indeed hard to see, however the $ signs in the output should have alarmed you ;)

user4628565 · Accepted Answer · 2015-08-19 16:22:20Z

0

try to change,

String test = String.format("$PNGVEST,%s,%d,%d,%f,%f,%f,$f,$f,$d",
        messageType, VEST_ID, System.currentTimeMillis(), lat, lon, ele,
        speed, heading, messageCode);

to

String test = String.format("$PNGVEST,%s,%d,%d,%f,%f,%f,%f,%f,%d",
        messageType, VEST_ID, System.currentTimeMillis(), lat, lon, ele,
        speed, heading, messageCode);

answered Aug 19, 2015 at 16:22

user4628565

Collectives™ on Stack Overflow

Java string.format() only half working

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related