Linq Entity Framework generic filter method

Question

I have some methods which perform a standard filter on data from my Entities (using Entity Framework v4).

Example #1:

protected IQueryable<Database.Product> GetActiveProducts( ObjectSet<Database.Product> products ) {

    var allowedStates = new string[] { "Active" , "Pending" };

    return (
        from product in products
        where allowedStates.Contains( product.State )
            && product.Hidden == "No"
        select product
    );

}

Example #2:

protected IQueryable<Database.Customer> GetActiveProducts( ObjectSet<Database.Customer> customers ) {

    var allowedStates = new string[] { "Active" , "Pending" };

    return (
        from customer in customers
        where allowedStates.Contains( customer.State )
            && customer.Hidden == "No"
        select customer
    );

}

As you can see, these methods are identical apart from the Entity types they operate on. I have more than 10 of these types of methods, one for each type of Entity in my system.

I am trying to understand how I could have 1 single method for which I could pass in any Entity type, and have it perform the where clause if the 2 fields/properties exist.

I do not use Inheritance in the database, so as far as the system goes, it is coincidental that each of the Entity types have the fields "Hidden" and "State".

My Googling tells me it has something to do with building code using Expression.Call() but my head is now spinning!

Stephen Cleary · Accepted Answer · 2010-07-10 20:03:18Z

7

I'd say adding interfaces is a simpler option than messing with the expression tree or reflection. EF entities are partial classes, so you should be able to do something like:

Updated to include class constraint (see Mark's comment)

public interface IHideable
{
  string State { get; }
  string Hidden { get; }
}

...

namespace Database
{
  public partial class Product : IHideable { }
  public partial class Customer : IHideable { }
}

...

protected IQueryable<T> GetActive<T>(ObjectSet<T> entities)
    where T : class, IHideable
{
  var allowedStates = new string[] { "Active" , "Pending" };    

  return (    
    from obj in entities
    where allowedStates.Contains(obj.State)
        && obj.Hidden == "No"
    select obj
  );
}

edited Jul 10, 2010 at 20:03

answered Jul 10, 2010 at 18:00

Stephen Cleary

460k78 gold badges721 silver badges858 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Mark H Over a year ago

I'd prefer this solution also. BTW, you need a class constraint because ObjectSet expects one. where T : class, IHideable

Stephen Cleary Over a year ago

Good catch, Mark; +1. I had not actually compiled it. Updated the sample to include class constraint.

Muhammad Hasan Khan Over a year ago

Thank you Mark H for mentioning the class constraint

danleis · Accepted Answer · 2010-12-20 00:48:53Z

3

I wanted to do the same thing with IQueryable<T> as an input parameter type for the generic method.

I got the runtime exception of "Unable to cast the type.... LINQ to Entities only supports casting Entity Data Model primitive types".

After some time I recognized, I forgot to add the class constraint for the generic parameter. However IQueryable<T> does not require to have the class constraint, it still needs that to resolve the types at runtime.

It would have taken me hours, without this post. Thanks :)

answered Dec 20, 2010 at 0:48

danleis

311 bronze badge

Collectives™ on Stack Overflow

Linq Entity Framework generic filter method

2 Answers 2

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related