php mysql_fetch_array() not working as expected

Question

$result = mysql_query($strSql);
foreach($bestmatch_array as $restaurant)
        {   
            while($row = mysql_fetch_array($result))
            {   
                if($restaurant == $row[0])
                {
                    $value = $row[1];
                }
            }
        }

What I am trying to do is sort the result of array formed by query according to the values stored in $bestmatch array.

I don't know what I am doing wrong but the 4th line just seems to run once. Please help guys. Thanx in advance.

Hanky Panky · Accepted Answer · 2015-08-31 05:59:50Z

1

php mysql_fetch_array() not working as expected

Your expectation is not right.

foreach($bestmatch_array as $restaurant)
        {   
            // This loop will only run for first iteration of your foreach.
            while($row = mysql_fetch_array($result))
            {

            }
            // everything has been fetched by now.
        }

That is a logically incorrect sequence.

You expect your inner loop to be called over and over again as many times as you have the outer loop run but record fetch does not work like that. For outer loop's first run all the rows in $result will be fetched and since you do not reset the counter after your while loop that means after the first run there will be no more rows for the next run.

Solution? Fetch the row from mysql first then use a simple in_array call to check whether that restaurant is there in your array.

$result = mysql_query($strSql);
while($row = mysql_fetch_array($result))
{   
     $name=$row[0];
     if(in_array($name,$bestmatch_array))
        $value=$name;
}

edited Aug 31, 2015 at 5:59

answered Aug 31, 2015 at 5:56

Hanky Panky

46.9k9 gold badges76 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

Nick Over a year ago

Got your point. But is there a modification by which I can achieve it.?

Nick Over a year ago

but it will not show the result in the same order as the $bestmatch_array. I want result to come in same sequence as in best match array. All the values are present in the result but I want to organize them as in bestmatch array.

Hanky Panky Over a year ago

If all the values are present and you want to match them to a fixed order why not the best match array itself? Since this is not a way to sort.

Nick Over a year ago

because bestmatch array has just the id. while the result generated by the query has around 100 fields.

Hanky Panky Over a year ago

That makes it even easier. Implode your best match array into a comma separated string then edit your query to say ORDER BY FIND_IN_SET($csvValues) and then you don't need to do anything else.

|

Luthando Ntsekwa · Accepted Answer · 2015-08-31 06:10:40Z

0

Store the results of the query in the array first:

$result = mysql_query($strSql);
$results_row = array();
while($row = mysql_fetch_array($result))
        {   
            $results_row[] = array($row[0],$row[1]);
        }

foreach($bestmatch_array as $restaurant)
    {   
        foreach ($results_row as $key => $value) 
          {
            if($restaurant == $results_row[$key][0])
            {
                $value = $results_row[$key][1];
            }
        }
    }

edited Aug 31, 2015 at 6:10

answered Aug 31, 2015 at 6:01

Luthando Ntsekwa

4,2486 gold badges25 silver badges53 bronze badges

Collectives™ on Stack Overflow

php mysql_fetch_array() not working as expected

2 Answers 2

10 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

10 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related