Javascript function that return an array of values

Question

this function read the current selected values from a table, I can't get the list of them in a single array readable outside this function.

function getcheckboxed() {
vartoberead = [];
$("input:checkbox[name=test]:checked").each(function(){
    vartoberead [vartoberead .length] = $(this).val();
     console.log($(this).val(), vartoberead);
     return vartoberead;
});

I've declared vartoberead, both inside, than outside the function, tried with:

var myoutsidevar = getcheckboxed();

but always return

[undefined]

Every help is appreciated

Side note. Instead of manually supplying the index you can use this syntax- vartoberead.push($(this).val()); — micah
– micah, Commented Aug 31, 2015 at 14:16

tymeJV · Accepted Answer · 2015-08-31 14:45:57Z

7

You can shorten this up a bit:

var values = $("input:checkbox[name=test]:checked").map(function() {
    return this.value;
}).get();

Edit: To make this a function and return:

function getcheckboxed() { 
    return $("input:checkbox[name=test]:checked").map(function() {
        return this.value;
    }).get();
}

edited Aug 31, 2015 at 14:45

answered Aug 31, 2015 at 14:13

tymeJV

105k14 gold badges165 silver badges158 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Curtis Over a year ago

What does get() do in this instance?

tymeJV Over a year ago

.get() creates the basic Array @Curt -- else it'll be a jQuery object.

user2239318 Over a year ago

this run fine outside a function, is there a way to put it inside a function? if I do: function getcheckboxed() { var levalues = $("input:checkbox[name=dalinkare]:checked").map(function() { return this.value; }).get(); return levalues;}

tymeJV Over a year ago

@user2239318 -- Yeah, that'll work - ill update the answer to include it in a function.

tymeJV Over a year ago

@user2239318 -- Edited the answer

baao · Accepted Answer · 2015-08-31 14:13:54Z

2

You can use map:

var vartoberead = $("input:checkbox[name=test]:checked").map(function(){
      return $(this).val();
});

map() does actually return something, so you don't need to push to an array but instead just let jQuery fill the array for you with the returned values.

answered Aug 31, 2015 at 14:13

baao

73.5k18 gold badges152 silver badges208 bronze badges

Comments

Fabrizio Calderan · Accepted Answer · 2015-08-31 14:15:00Z

0

you should return after the each() cycle (and not inside the cycle as you're doing) anyway you could also use serializeArray

function getcheckboxed() {
   return $("input:checkbox[name=test]:checked").serializeArray();
};

answered Aug 31, 2015 at 14:15

Fabrizio Calderan

124k26 gold badges171 silver badges183 bronze badges

Comments

Kevin Gutierrez · Accepted Answer · 2015-08-31 14:29:55Z

0

When you print the value inside de each ( console.log($(this).val(), vartoberead); ) it show the values correctly ?

Other thing is that you are returning the value inside the each.

Try this:

function getcheckboxed() {
    vartoberead = [];
    $("input:checkbox[name=test]:checked").each(function(){
        vartoberead.push($(this).val());
    });
    return vartoberead;
}

answered Aug 31, 2015 at 14:29

Kevin Gutierrez

161 silver badge4 bronze badges

Comments

Rohit Kumar · Accepted Answer · 2015-08-31 14:31:01Z

I have a pure javascript solution for this . I have used html array i.e all checkboxes having same name (say test[])

function getCheckBoxesValues()
{
	var values=[];
    for(var i=0;i<document.getElementsByName('test[]').length;i++)
         
                {
                        if((document.getElementsByName('test[]')[i]).checked)
							{
								values.push((document.getElementsByName('test[]')[i]).value);
							}
                }
	return values;			
}

<input type="checkbox" name="test[]" value="c1"/>
<input type="checkbox" name="test[]" value="c2"/>
<input type="checkbox" name="test[]" value="c3"/>
<input type="checkbox" name="test[]" value="c4"/>
<input type="checkbox" name="test[]" value="c5"/>
<button onClick="alert(getCheckBoxesValues());">Result</button>

yyf · Accepted Answer · 2015-08-31 14:31:04Z

0

You have to modify you code to valid JavaScript code. That is: vartoberead [vartoberead .length] should be vartoberead[vartoberead.length] without any spaces. Beside this issue everything else is ok with your code.

Just by looking at your code I would rather use vartoberead.push($(this).val()) to add to the returned array than looking at the arrays length.

answered Aug 31, 2015 at 14:31

yyf

255 bronze badges

Collectives™ on Stack Overflow

Javascript function that return an array of values

6 Answers 6

5 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

5 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related