9

I'm following the React Tutorial and got stuck on how to use React.findDOMNode.

Here is my code:

export class CommentForm extends React.Component<{}, {}> {
    handleSubmit(e: React.FormEvent) {
        e.preventDefault();
        console.log(React.findDOMNode(this.refs['author']));
    }

    render() {
        return <form className="commentForm" onSubmit={ e => this.handleSubmit(e) }>
                 <input type="text" placeholder="Your name" ref="author" />
                 <input type="text" placeholder="Say something..." ref="text" />
                 <input type="submit" value="Post" />
               </form>;
    }
}

Calling console.log(React.findDOMNode(this.refs['author'])); gives me back <input type="text" data-reactid=".0.2.0" placeholder="Your name"> in the console. However, I cannot figure out how to retrieve the value of the input element (what I typed in the input box).

So far I've tried the following along with a few others:

React.findDOMNode(this.refs['author']).value; // "value" does not exist on type "Element"
React.findDOMNode(this.refs['author']).getAttribute('value'); // null
React.findDOMNode(this.refs['author']).textContent; // null

In intellisense I can see the following, but I still cannot figure out what to call here. enter image description here

I'm using the type definitions from DefinitedlyTyped. Also, I'm new to front-end development, so maybe my approach is wrong.

Improve this question

5 Answers 5

Reset to default
12

Note that the tutorial is written in JavaScript, not TypeScript.

However, I have found the solution to doing this properly (OP's answer is very cumbersome). Basically, you have to make two changes from the tutorial code. For reference, here is the code from the tutorial as of me writing this:

var author = React.findDOMNode(this.refs.author).value.trim();

The first change is:

this.refs.author

Becomes

this.refs["author"]

I'm new to TypeScript, but I assume that it prefers you use indexer syntax over property syntax for objects that are meant to not have their true properties forward-declared.

Second, and most importantly,

React.findDOMNode

Becomes

React.findDOMNode<HTMLInputElement>

Basically here we have to specifically tell TypeScript what kind of element we are requesting. Use your code-complete to find a complete list of elements available. I assume it covers all intrinsic components.

Here is the final, working, line of code:

var author = React.findDOMNode<HTMLInputElement>(this.refs["author"]).value.trim();

For convenience, here is the completed method up to the point where this method first appears in the tutorial (slightly refactored to avoid invoking findDOMNode twice):

handleSubmit(e: React.FormEvent) {
    e.preventDefault();

    var authorInput = React.findDOMNode<HTMLInputElement>(this.refs["author"]);
    var textInput = React.findDOMNode<HTMLInputElement>(this.refs["text"]);

    var author = authorInput.value.trim();
    var text = textInput.value.trim();

    if (!text || !author)
        return;

    authorInput.value = textInput.value = "";
}
Improve this answer
Sign up to request clarification or add additional context in comments.

3 Comments

Thanks! I actually tried HTMLElement and a few other types, but they didn't work. I see now that to get value you have to use the HTMLInputElement interface. Knowing which type is a little tricky.
I am using React.findDOMNode<HTMLInputElement> and getting findDOMNode does not exist on 'typeof _React'. Any idea?
Answering myself... using import * as ReactDOM from 'react-dom'; and then ReactDOM.findDOMNode<HTMLInputElement> solved my problem
6

I found this way to solve this issue.

const author = (ReactDOM.findDOMNode(this.refs.author) as HTMLInputElement).value;
Improve this answer

1 Comment

Welcome to StackOverflow. Answers with only code in them tend to get flagged for deletion as they are "low quality". Please read the help section on answering questions then consider adding some commentary to your Answer.
0

References in React doesn't work like this. To get the DOM element of reference, you need to ask it in that way :

let authorElement = this.refs.author.getDOMNode();
Improve this answer

2 Comments

Hi, I tried out your example, but getDOMNode does not exist on Component. Here is the declaration. It does exist on ClassicComponent which I'm not using.
This question is marked as TypeScript, not JavaScript. The .d.ts files included via tsd do not include a getDOMNode method.
0

EDIT: nlaq provided the answer to my question, however I think the following can be useful for readers, so I will leave this answer up.

After reading Forms | React article, I was able to acquire the value by handling the onChange event:

handleChange(e) {
    e.preventDefault();
    console.log(e.target.value); // e.target.value gives the value in the input box
}

render() {
    return <form className="commentForm" onSubmit={ e => this.handleSubmit(e) }>
             <input type="text" onChange={ e => this.handleChange(e) } placeholder="Your name" />
             <input type="text" placeholder="Say something..." ref="text" />
             <input type="submit" value="Post" />
           </form>;
}

I'm still puzzled why the tutorial showed the use of findDOMNode. Perhaps the tutorial is showing an old way? I'm still new to React, so if there is a more intuitive way please let me know.

For a full example, this SO answer helped me out.

Improve this answer

1 Comment

Check out my answer, it's presumably the proper way to handle this. The issue you're having is not because it's an old way of doing things, it's because TypeScript requires us to properly specify the type information.
0

None of the above solutions quite worked for me (and I think this might be a simpler solution). This is how I managed to get it to work in typescript (example using refs to focus the FormControl):

Make sure you've imported ReactDom:

import * as ReactDOM from 'react-dom';

In your component:

public focus():void {
    let input = ReactDOM.findDOMNode(this.refs["titleInput"]) as HTMLInputElement;
    input.focus();
}

render() {
    return (
        <FormGroup controlId="formBasicText">
            <FormControl ref={"titleInput"} type="text"/>
        </FormGroup>
    );
}
Improve this answer

Comments

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.