Creating Password Checker with Java Methods

Question

Can some one please help me figure out my errors in the Program.Java. there are two separate files which i separated with a comment. I am having trouble trying to get my methods to work. The point is for a user to input a password. if the old password is the same as changeit then old password can become newpassword. Please help!!

    //my Main.Java File
package Main;
import java.util.Scanner;
public class Main {
   public static void main(String[] args) {
        //initialize the scanner, old password and new password//

        Scanner passwordScanner = new Scanner(System.in);
        String oldPassword;
        String newPassword;

        //initializing password object//

        Password passwordObject = new Password();

        //ask user for old password and new password//

        System.out.println("Please enter your old password: ");
        oldPassword = passwordScanner.nextLine();

        System.out.println("Please enter your new password: ");
        newPassword = passwordScanner.nextLine();

        //Call the methods//

        passwordObject.checkPassword(oldPassword);
        passwordObject.changePassword(oldPassword, newPassword);

    }

}


//-----------------------------------------------------------------------//
//my Password.java file
package Main;

public class Password {
    //intialize password to change it//
    String password = "changeit";
    String somePassword;
    boolean succefulChange;

    //Check password method//

    public boolean checkPassword(String somePassword);

    //return true is some password is same as old password, if not then return false//
    if (somePassword.equals(oldPassword))

        return true;
    else

        return false; 


    //Change password method//
    public void changePassword(String oldPassword, String newPassword);



    //Change old password to new password if old password is true//
    if (oldPassword.equals(password))

        oldPassword.setText(newPassword); 


}

But there is no Program.Java.

SatyaTNV
– SatyaTNV

2015-09-22 16:55:02 +00:00
Commented Sep 22, 2015 at 16:55 — SatyaTNV
– SatyaTNV, Commented Sep 22, 2015 at 16:55
That is not the proper syntax for a method

jthort
– jthort

2015-09-22 16:59:26 +00:00
Commented Sep 22, 2015 at 16:59 — jthort
– jthort, Commented Sep 22, 2015 at 16:59

jsheeran · Accepted Answer · 2015-09-22 16:59:52Z

1

Your syntax for declaring methods is wrong. It should look like this:

//Change password method//
public void changePassword(String oldPassword, String newPassword) {
  //Change old password to new password if old password is true//
  if (oldPassword.equals(password))
      oldPassword.setText(newPassword); 
}

Except oldPassword is a String which doesn't have a setText method, so that won't work either.

answered Sep 22, 2015 at 16:59

jsheeran

3,0372 gold badges19 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ravindra babu · Accepted Answer · 2015-09-22 17:23:09Z

0

Body of method always should be embedded between braces "{" and "}"

Even for single if condition, always use braces "{" and "}"

public boolean checkPassword(String somePassword){

    if (somePassword.equals(oldPassword)){
        return true;
    }
    else{
        return false; 
    }
}


public void changePassword(String oldPassword, String newPassword){

    if (oldPassword.equals(password)){
        oldPassword.setText(newPassword); 
    }
}

answered Sep 22, 2015 at 17:23

Ravindra babu

39.1k11 gold badges258 silver badges222 bronze badges

Comments

E.Brandonn · Accepted Answer · 2015-09-22 18:07:28Z

I made some changes to your code: looks Comments

//my Main.Java File
package Main;
import java.util.Scanner;
public class Main {
public static void main(String[] args) {
Scanner passwordScanner = new Scanner(System.in);
    String oldPassword;
    String newPassword;

    Password passwordObject = new Password();

    System.out.println("Please enter your old password: ");
    oldPassword = passwordScanner.nextLine();

    System.out.println("Please enter your new password: ");
    newPassword = passwordScanner.nextLine();


    passwordObject.checkPassword(newPassword,oldPassword);
    newPassword = passwordObject.changePassword(oldPassword, newPassword); // here old password can become newpassword

}

}

  //-----------------------------------------------------------------------   //
//my Password.java file
package Main;

public class Password {

     String password = "changeit";
     String somePassword;
     boolean succefulChange;

public boolean checkPassword(String somePassword,String oldPassword){  // take two password for check and begin method with "{" not ";"


if (somePassword.equals(oldPassword))

    return true;
else

    return false; 
}


public String changePassword(String oldPassword, String newPassword){ //begin method with "{" not ";" and change void method to String to return the new password 




if (oldPassword.equals(password)){

                                      //for testing:  System.out.println("old password is the same as changeit he can become new password");
     return newPassword;  //String doesn't have a setText method so return the newPassword if password="changeit"
 }
else{
                                   //for testing: System.out.println("old password is not the same as changeit he can not become new password");
    return oldPassword; //if password is not equal to "changeit" it can not be changed so return the old one

        }
 }

}

Collectives™ on Stack Overflow

Creating Password Checker with Java Methods

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related