.Each function JavaScript Iterating twice in XML

Question

I am trying to iterate through the xml with jquery and posting it on html. For some reason the each function in authors is appending duplicates. For example, I will get James McgovernPer BothnerKurt BothernerKurt CagleJames Linn Valiyanathan Nagarjan, James McgovernPer BothnerKurt BothernerKurt CagleJames Linn Valiyanathan Nagarjan. I was wondering how can I fix this? Thanks!

<book category="web">
<title lang="en">XQuery Kick Start</title>
<author>James McGovern</author>
<author>Per Bothner</author>
<author>Kurt Cagle</author>
<author>James Linn</author>
<author>Vaidyanathan Nagarajan</author>

$(document).ready(function() {
$.ajax({

     url: "books.xml",
     dataType: "xml",
     success: function(data) {

        $(data).find('book').each(function(){
        var category = $(this).attr('category');
        var title = $(this).find('title').text();
        var year = $(this).find('year').text();
        var price = $(this).find('price').text();
        var author = $(this).find('author').text();

        $(this).find('author').each(function(){
            author += $(this).text();
            author += ',';
        });

        var r = '<tr>';
        r += '<td>' + title + '</td>';
        r += '<td>' + author + '</td>';
        r += '<td>' + year + '</td>';
        r += '<td>' + price + '</td>';
        r += '<td>' + category + '</td>';

        $('table').append(r);
        });

     },
     error: function() { alert("error loading!");  }
 });

});

miniBill · Accepted Answer · 2015-09-23 20:39:30Z

2

You are first setting auther to $(this).find('author').text(), and THEN appending the rows in the each. This causes the list to be repeated.

You should probably just replace the first assignment with a var author = ''.

answered Sep 23, 2015 at 20:39

miniBill

1,73318 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

charlietfl · Accepted Answer · 2015-09-23 20:47:05Z

2

need to replace

var author = $(this).find('author').text();

with

var author ='';

the first one will concatenate the text of all of those elements without any spaces ... and then you are looping over the elements individually and adding to it.

To get rid of the trailing comma in author can change to:

var author =[];
$(this).find('author').each(function(){
    author.push( $(this).text());
});    
author = author.join(', ');

// or

var author = $(this).find('author').map(function(){
      return $(this).text();
}).get().join(', ');

edited Sep 23, 2015 at 20:47

answered Sep 23, 2015 at 20:39

charlietfl

172k14 gold badges125 silver badges154 bronze badges

Collectives™ on Stack Overflow

.Each function JavaScript Iterating twice in XML

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related