JQuery explode prompt result not working when loading a URL

Question

I am trying to create a script that asks for a YouTube video link and following explodes it and automatically inserts it into the editor.

The trick is however not working.

function TinyMCEInsertYouTube() {
    var YouTubeLink     = encodeURIComponent(prompt("Please insert the YouTube link"));
    var result          = $(YouTubeLink).text().split('watch?v=');
    var VideoIDParam    = result[1];

    var VideoHeight     = prompt("Please enter the video height");
    var VideoWidth      = prompt("Please enter the video width");

    var InsertCode = '<iframe width="' + VideoWidth + '" height="' + VideoHeight + '" src="https://www.youtube.com/embed/' + VideoIDParam + '" frameborder="0" allowfullscreen></iframe>'

    tinyMCE.activeEditor.insertContent( InsertCode );
}

It generates the following error :

Error: Syntax error, unrecognized expression: https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DrPpO65UbM6Y

I already tried to add the following tags : encodeURIComponent()

But to no result

I tried to add escape() instead of encodeURIComponent Also no result.

Gave the following error :

Error: Syntax error, unrecognized expression: https%3A//www.youtube.com/watch%3Fv%3DrPpO65UbM6Y

Edit!

It works!! Thanks to @SearchAndResQ

The following code :

function TinyMCEInsertYouTube() {
    var YouTubeLink     = prompt("Please insert the YouTube link");
    var result          = YouTubeLink.split('watch?v=');
    var VideoIDParam    = result[1];

    var VideoHeight     = prompt("Please enter the video height");
    var VideoWidth      = prompt("Please enter the video width");

    var InsertCode = '<iframe width="' + VideoWidth + '" height="' + VideoHeight + '" src="https://www.youtube.com/embed/' + VideoIDParam + '" frameborder="0" allowfullscreen></iframe>'

    tinyMCE.activeEditor.insertContent( InsertCode );
}

Flakes · Accepted Answer · 2015-10-05 09:49:46Z

2

YouTubeLink is a variable containing the inputted text. you can split it directly:

var result = YouTubeLink.split('watch?v=');

And you don't need to encodeURIComponent

edited Oct 5, 2015 at 9:49

answered Oct 5, 2015 at 9:40

Flakes

2,3608 gold badges32 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Phylogenesis Over a year ago

Another problem is that the link is URI Encoded. As such, the split() will not actually split anything as the ? is encoded as %3F.

Phylogenesis Over a year ago

But escape() does exactly the same thing to ?

Flakes Over a year ago

You are right again (I am not that good in javascript, obviously). Wonder how it works for him, maybe he is not using escape anymore. You can down vote this if you feel it is not helping anyone.

shrmn Over a year ago

The link is saved in the variable YouTubeLink from the prompt.

YaBCK · Accepted Answer · 2015-10-05 10:17:32Z

1

You can directly split the Youtube link because YoutubeLink is the variable containing the inputted text.

Also there is no need for encodeURIComponent

Check this example i've done for you:

JSFIDDLE EXAMPLE

edited Oct 5, 2015 at 10:17

answered Oct 5, 2015 at 9:46

YaBCK

3,0394 gold badges36 silver badges71 bronze badges

Collectives™ on Stack Overflow

JQuery explode prompt result not working when loading a URL

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related