angularjs api , return object

Question

i work with Riot game API , a create a factory and use where i need get and sort data

        angular.module('starter.services', [])

    .factory('API',function($http){
    var data={};
    var token = "****";
    return{
        Getalldata : function(name){


            $http.get("https://eune.api.pvp.net/api/lol/eune/v1.4/summoner/by-name/" + name, {
          params: {
            api_key: token
          }
        })
        .success(function(response, error) {

          var dbc = [];
          //console.log(response);
          res = response[name];
          //console.log(res);
          id = res.id;


          //$scope.img = "http://sk2.op.gg/images/profile_icons/profileIcon"+res.profileIconId+".jpg";
          $http.get("https://eune.api.pvp.net/api/lol/eune/v1.3/stats/by-summoner/" + res.id + "/summary", {
              params: {
                season: "SEASON2015",
                api_key: token
              }
            })
            .success(function(response, error) {
              //$scope.stat=response.playerStatSummaries
              response.playerStatSummaries.forEach(function(entry) {
                  //console.log(entry);
                  if(entry.playerStatSummaryType=="Unranked"){

                    data.norank5x5=entry;
                  }
                  if(entry.playerStatSummaryType=="CAP5x5"){
                    data.team5x5=entry;
                  }
                  if(entry.playerStatSummaryType=="Unranked3x3"){
                    data.unrank3x3=entry;
                  }
                  if(entry.playerStatSummaryType=="RankedTeam3x3"){
                    data.rank3x3=entry;
                  }
                  if(entry.playerStatSummaryType=="RankedTeam5x5"){
                    data.rank5x5=entry;
                  }

                  //console.log(data.team5x5);

              });
              //console.log(data);
            //return data;

          });

        });

        return date;
        }
        /*getRankData : function(name,sezin){

            mydata = "kola";
            return mydata;

        }*/
    };
});

and use this factory , but in controller in Click i use my factory i get "undefined", how i can get my object ? Controller code :

.controller('MainCtrl', function($scope,$rootScope,$ionicLoading,API) {

  $scope.showmenu = function(){
        console.log(API.Getalldata("fenix"));
    }

});

can you please provide any errors you are getting? Is your API call working if you hard code in "fenix"? — Chris L
– Chris L, Commented Oct 12, 2015 at 19:38
yes , i dont have errors , if i do factory code in controller all fine. — user2420249
– user2420249, Commented Oct 12, 2015 at 19:47
see answer below. You are returning "date" not "data" please click check and like if that ends up being your problem. :-) — Chris L
– Chris L, Commented Oct 12, 2015 at 19:49
no no , I typed in the editor stackoverflow this error , sorry — user2420249
– user2420249, Commented Oct 12, 2015 at 19:56
show us the onClick ... you don't use that for angular code ... operates in different context — charlietfl
– charlietfl, Commented Oct 12, 2015 at 19:56

Vladimir Zdenek · Accepted Answer · 2015-10-12 19:52:05Z

3

Return the $http inside the function. Then in the $scope function, do:

API.Getalldata("something").then(function(response) { console.log(response) });

Please note I have not tried this myself, but it should work/help you to get it working.

Btw: returning the date/data is useless as $http is a promise and the variable will not be resolved by the time the value is supposed to be returned.

edited Oct 12, 2015 at 19:52

answered Oct 12, 2015 at 19:41

Vladimir Zdenek

2,2901 gold badge20 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

user2420249 Over a year ago

I try and get "TypeError: undefined is not a function". if do API.Getalldata("fenix"); get empty object

user2420249 Over a year ago

have i can get result in the time ?

Chris L Over a year ago

he's right. No you can't get the result in "real time."

user2420249 Over a year ago

what I need to use to get in on time ?

user2420249 Over a year ago

get answer , i use var deferred = $q.defer(); in my factory and then deferred.resolve({ data1:data }); and then return deferred.promise; in controller get my obj console.log(API.Getalldata("fenix"));

Chris L · Accepted Answer · 2015-10-12 19:48:21Z

0

I think I found your problem. You are returning "date" not "data"

angular.module('starter.services', [])

.factory('API',function($http){
var data={};
var token = "****";
return{
    Getalldata : function(name){

     [..edited..]

    });

    return date; // HERE, I THINK IS YOUR PROBLEM
    }
    /*getRankData : function(name,sezin){

        mydata = "kola";
        return mydata;

    }*/
};});

edited Oct 12, 2015 at 19:48

answered Oct 12, 2015 at 19:41

Chris L

1,0611 gold badge8 silver badges21 bronze badges

Collectives™ on Stack Overflow

angularjs api , return object

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related