java - How to return random String from an array using methods?

Question

I need to make a method that randomly chooses one of the strings in my "carmake" array. I am stuck in my setCarMake method. The same applies for the color of the car(that method will be made after i finish this one). Here is my current code.

public class Cars {

    public String[] carmake = {"Audi", "BMW" , "Mercedes-Benz", "Lexus", "Volkswagen"};
    public String[] carcolor = {"Black", "Yellow", "Red", "Grey"};
    //
    public int caryear;
    public int speed;

    public void setCarMake(){
        Random rand = new Random(14335);
        carmake.rand.nextInt(carmake.length);
    }

    public int GetYear(){
        int max = 2015;
        int min = 1999;

        Random rand = new Random();
        caryear = rand.nextInt((max-min)+1) + min ;
        return caryear;
    }

    public void execute(){
        System.out.println(caryear + " " + carmake);
    }
}

Please help!

setCarMake() does not return a value. You need to set the return type to String and add a return statement. — Bethany Louise
– Bethany Louise, Commented Oct 31, 2015 at 20:49

sam · Accepted Answer · 2015-10-31 20:52:22Z

4

This is wrong:

carmake.rand.nextInt(carmake.length);

Because it means that rand is an method of carmake array?? Doesn't make sense, right? That's what dot . operator does. They are used to access method.

Try this:

int carMakeRandomIndex = new Random().nextInt(carmake.length);
return carmake[carMakeRandomIndex];

Also, please follow the naming convention.

answered Oct 31, 2015 at 20:52

sam

2,0232 gold badges12 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

sam Over a year ago

@ChuckBIhekwaba Check working demo . Show how you are calling that method

Chuck B Ihekwaba Over a year ago

how do i print the car name as a string? it only returns the index number not the name.

sam Over a year ago

@ChuckBIhekwaba If you return carMakeRandomIndex, it will return index, if you return carmake[carMakeRandomIndex], it will return car name at that index. Show your code if you still have trouble and I will take a look at it

Tadej Gašparovič · Accepted Answer · 2015-10-31 21:01:18Z

2

I think you just need to get a random number in the range of the array (0 to carmake.length - 1) and then use that as the array index.

rand.nextInt(carmake.length); //This should work

edited Oct 31, 2015 at 21:01

answered Oct 31, 2015 at 20:54

Tadej Gašparovič

1601 gold badge3 silver badges12 bronze badges

Comments

Jameson · Accepted Answer · 2015-10-31 20:50:47Z

1

Here is an approach to obtain a random element from the carmake array:

final int randomIndex = rand.nextInt() % rcarmake.length;
return carmake[randomIndex];

answered Oct 31, 2015 at 20:50

Jameson

6,7296 gold badges37 silver badges58 bronze badges

3 Comments

Henry Over a year ago

the expression rand.nextInt() % rcarmake.length may be biased in the sense that not all index values appear with the same probability.

Chuck B Ihekwaba Over a year ago

[Ljava.lang.String;@677327b6 - that is the output for your code. Similar thing happened to me earlier.

Tom Over a year ago

@ChuckBIhekwaba this is not the output of his code snippet. Your trying to print 'carmake', not the returned random String.

Collectives™ on Stack Overflow

java - How to return random String from an array using methods?

3 Answers 3

3 Comments

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related