CodeIgniter result_array() on boolean error if the table is empty

Question

I have this function in my Carros_model.php that is used to bring the last insertions and display them in the dashboard:

public function select_all($limit = 3)
{
    $this->db
        ->select('marca.nome_marca,'
               . 'combustivel.nome_combustivel,'
               . 'cambio.descricao_cambio,'
               . 'DATE_FORMAT(carro.data_criacao, "%d/%m/%Y") as criacao,'
               . 'DATE_FORMAT(carro.data_modificacao, "%d/%m/%Y") as modificacao,'
               . 'carro.*')
        ->from('carro')
        ->join('marca', 'marca.id = carro.id_marca')
        ->join('combustivel', 'combustivel.id = carro.id_combustivel')
        ->join('cambio', 'cambio.id = carro.id_cambio')
        ->order_by('carro.id', 'DESC')
        ->limit($limit, 0);

    $query = $this->db->get();

    foreach ($query->result_array() as $row) {
        $data[] = $row;
    }

    $query->free_result();

    return $data;
}

It works fine, but I discovered that if the table is empty, the error

Fatal error: Call to a member function result_array() on boolean

is thrown. How do I solve this?

just check the content of the variable $query before the loop, if it's an empty array then you can't call result_array on it — teeyo
– teeyo, Commented Dec 1, 2015 at 19:31

gen_Eric · Accepted Answer · 2015-12-01 19:30:22Z

11

You should be checking to see if the query worked/has any rows before trying to get its results. If the table is empty, then the query won't do anything.

$query = $this->db->get();

$data = array();
if($query !== FALSE && $query->num_rows() > 0){
    foreach ($query->result_array() as $row) {
        $data[] = $row;
    }
}

return $data;

P.S. There's no reason to use a loop over $query->result_array(), you can just return that. It's already an array of rows.

$query = $this->db->get();

$data = array();
if($query !== FALSE && $query->num_rows() > 0){
    $data = $query->result_array();
}

return $data;

answered Dec 1, 2015 at 19:30

gen_Eric

228k42 gold badges304 silver badges343 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user4383363 Over a year ago

Nice. Now I must find a way to check in my view to see if there is any data, because it is accusing Invalid argument supplied for foreach().

gen_Eric Over a year ago

@mfgabriel92: Try is_array().

Tariq · Accepted Answer · 2015-12-01 19:22:02Z

0

Make this change in your code (Add $data array after the $query):

$query = $this->db->get();
$data = Array();
foreach ($query->result_array() as $row) {
    $data[] = $row;
}

This happens because $data variable doesn't exist unless you create an empty variable before the loop in case there are no results.

answered Dec 1, 2015 at 19:22

Tariq

2,8813 gold badges24 silver badges29 bronze badges

1 Comment

gen_Eric Over a year ago

While a good idea, this isn't the source of the issue. You can do $data[] = ...; without declaring $data, you shouldn't but you can. See: php.net/manual/en/…

Collectives™ on Stack Overflow

CodeIgniter result_array() on boolean error if the table is empty

2 Answers 2

2 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related