javascript regex to replace all img src with data-src

Question

i want to replace all img src with data-src and this is my pattern :

(<img.*?)src

but this one is also matching data-src so when i use in on a loop it ouput something like that

<img data-data-data-data-data-data-data-data-data-data-data-data-data-data-src="..">

any help ?

Why would you be running this over and over in a loop?

user663031
– user663031

2015-12-07 06:19:12 +00:00
Commented Dec 7, 2015 at 6:19 — user663031
– user663031, Commented Dec 7, 2015 at 6:19
Use the /g flag, don't run the same pattern in a loop.

Ultimater
– Ultimater

2015-12-07 06:27:26 +00:00
Commented Dec 7, 2015 at 6:27 — Ultimater
– Ultimater, Commented Dec 7, 2015 at 6:27

user663031 · Accepted Answer · 2015-12-07 06:18:03Z

4

Don't use regexp for this. Just

var images = document.querySelectorAll('img');
for (var i = 0; i < images.length; i++) {
  var img = images[i];
  img.dataset.src = img.src;
  img.src = '';
}

answered Dec 7, 2015 at 6:18

user663031

Sign up to request clarification or add additional context in comments.

Comments

Soronbe · Accepted Answer · 2015-12-07 06:15:34Z

0

(<img.*?)[^-]src will work, but regexes try to get the longest match, so

(<img[^>])[^->]src

would ne more correct.

answered Dec 7, 2015 at 6:15

Soronbe

9265 silver badges12 bronze badges

Comments

nu11p01n73R · Accepted Answer · 2015-12-07 06:22:44Z

0

Positive look aheads would be helpfull

<img(?![^>\n]*data-src)[^>\n]*src

Regex Demo

edited Dec 7, 2015 at 6:22

answered Dec 7, 2015 at 6:11

nu11p01n73R

26.8k3 gold badges42 silver badges52 bronze badges

Collectives™ on Stack Overflow

javascript regex to replace all img src with data-src

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related