Simple JS regex replace.

Question

I am struggling trying to create a really simple RegExp. (probably lacking some hours of sleep).

I just have has an input this string : /users/10/contracts/1 My regex is this one : /users/(\w+)/contracts/(\w+)/

I want to replace all matches with this kind of string : /users/{variable1}/contracts/{variable2}

Here is my complete source code :

var customRegex = "/users/(\\w+)/contracts/(\\w+)";
  var i =0;
  var finalUrl = "/users/1234/contracts/5678".replace(new RegExp(customRegex, 'gi'), function myFunction(x, y){
    return "{variable" + i + "}"; 
  });

  console.log(finalUrl);

Could you please help me?

I wish you a nice day and thank you for your help.

Use String#replace with a counter. var finalUrl = "/users/1234/contracts/5678"; var i = 1; finalUrl = finalUrl.replace(/\d+/g, function () { return "{variable" + i++ + "}"; }); console.log(finalUrl); — Tushar
– Tushar, Commented Jan 10, 2016 at 5:52

Jens · Accepted Answer · 2016-01-10 00:27:23Z

3

The replace-function is only called once for the whole replacement. You are using 2 matchers so you also get 2 matches as parameters in the callback-function.

var customRegex = "/users/(\\w+)/contracts/(\\w+)";
var finalUrl = "/users/1234/contracts/5678".replace(new RegExp(customRegex, 'gi'), function myFunction(wholeString, p1, p2){
    return wholeString.replace(p1, "{variable1}").replace(p2, "{variable2}"); 
});
console.log(finalUrl);

answered Jan 10, 2016 at 0:27

Jens

5751 gold badge8 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Tushar Over a year ago

You don't need i flag because \w matches both uppercase and lowercase alphabets

Freezer freezer Over a year ago

Thank you Jens. It was exactly what i wanted :)

Jens Over a year ago

@Tushar indeed, just copied it from his question. Maybe he simplified his question and is using a more complex pattern but for this one you are completly right, good hint.

Julio Betta · Accepted Answer · 2016-01-10 08:46:15Z

0

If you need to match the numbers only, it should do the work.

var finalUrl = "/users/1234/contracts/5678";

finalUrl.match(/\d+/g).forEach(function(v, i) { 
  finalUrl = finalUrl.replace(v, "{variable" + (i + 1) + "}"); 
});

document.write(finalUrl);

edited Jan 10, 2016 at 8:46

answered Jan 10, 2016 at 0:28

Julio Betta

2,2951 gold badge25 silver badges25 bronze badges

1 Comment

Tushar Over a year ago

You don't need i flag for numbers. Never heard of (upp|low)erCase numbers. :P

Collectives™ on Stack Overflow

Simple JS regex replace.

2 Answers 2

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related