Android check if multiple strings are not empty

Question

I have a form and I put the forms data in an intent and then start a new activity and send the data with the intent, but I wanna do a check if the strings are empty I should display and error message. If the strings are not empty the activity can be started.

I've tried the following code but it doesn't seem to be working. If the field is empty it just starts the other activity (I've tried with only 1 field for now, because I don't know how to to it for multiple fields)

    //getting the field values
    String firstname = editTextFirstname.getText().toString();
    String lastname = editTextLastname.getText().toString();
    String amount = editTextBedrag.getText().toString();
    String timespan = spinnerPeriode.getSelectedItem().toString();
    String iban = editTextIBAN.getText().toString();

    if(firstname != null) {
        //putting data in the intent
        intent.putExtra(FIRSTNAME, firstname);
        intent.putExtra(LASTNAME, lastname);
        intent.putExtra(AMOUNT, amount);
        intent.putExtra(TIMESPAN, timespan);
        intent.putExtra(IBAN, iban);

        startActivity(intent);
    }else{
        Toast.makeText(MainActivity.this, "Oops, you forgot to fill in some fields!", Toast.LENGTH_SHORT).show();
    }

user1244949 · Accepted Answer · 2016-01-10 15:26:10Z

7

A cleaner way to do this is

public static boolean isAnyStringNullOrEmpty(String... strings) {
    for (String s : strings)
        if (s == null || s.isEmpty())
            return true;
    return false;
}

Then you can call it like this

if (isAnyStringNullOrEmpty(firstname, lastname, amount, timespan, iban)) {
    Toast.makeText(MainActivity.this, "Oops, you forgot to fill in some fields!", Toast.LENGTH_SHORT).show();
} else {

}

answered Jan 10, 2016 at 15:26

user1244949

Sign up to request clarification or add additional context in comments.

Comments

Anant Simran Singh · Accepted Answer · 2018-04-04 09:21:02Z

5

Using apache commons, we can do this as:

boolean valid = StringUtils.isNoneEmpty(firstname, lastname, amount, timespan, iban)

answered Apr 4, 2018 at 9:21

Anant Simran Singh

6376 silver badges16 bronze badges

2 Comments

lorraine batol Over a year ago

Or I would say StringUtils#isNoneBlank. isNoneEmpty() considers space as a non-empty value where isNoneBlank() will say it's empty.

Anant Simran Singh Over a year ago

I appreciate you pointing it out in the comments- However, the question specifically asks for empty. Thankyou for your input though.

Mohammed Aouf Zouag · Accepted Answer · 2016-01-10 15:16:51Z

2

Change

if(firstname != null)

to

if(!TextUtils.isEmpty(firstname) && !TextUtils.isEmpty(lastname) &&
     !TextUtils.isEmpty(amount) &&!TextUtils.isEmpty(timespan) &&
     !TextUtils.isEmpty(iban))

answered Jan 10, 2016 at 15:16

Mohammed Aouf Zouag

17.2k4 gold badges44 silver badges68 bronze badges

1 Comment

Phd. Burak Öztürk Over a year ago

this answer is not correct, if you blank a field and run this code result is not correct

Marco Pelegrini · Accepted Answer · 2018-01-23 19:04:54Z

1

Java 8 + Apache Commons Lang only:

String firstname = editTextFirstname.getText().toString();
String lastname = editTextLastname.getText().toString();
String amount = editTextBedrag.getText().toString();
String timespan = spinnerPeriode.getSelectedItem().toString();
String iban = editTextIBAN.getText().toString();


boolean valid =  Stream.of(firstname, lastname, amount, timespan, iban)
                       .allMatch(StringUtils::isNotBlank);

answered Jan 23, 2018 at 19:04

Marco Pelegrini

5485 silver badges6 bronze badges

1 Comment

Sunny Over a year ago

what if i am gettng multiple strings from server and saving it to string now some of have a value but some of them are empty how to check which are empty and which have some values + how to set the values which are not empty to some specif fields??

Krishna Satwaji Khandagale · Accepted Answer · 2016-01-10 16:02:24Z

0

if(firstname != null && lastname != null && amount != null && timespan != null
 && iban != null & firstname.trim().isEmpty() && !lastname.trim().isEmpty() &&
 !amount .trim().isEmpty() && !timespan.trim().isEmpty() && !iban.trim().isEmpty())

answered Jan 10, 2016 at 16:02

Krishna Satwaji Khandagale

2,27018 silver badges25 bronze badges

1 Comment

Sunny Over a year ago

and what if it get any string not equal to null then how to get the value ?

GedankenNebel · Accepted Answer · 2020-06-17 23:30:40Z

0

Using Java Stream API:

private boolean anyBlank(String...strings) {
   return Stream.of(strings).anyMatch(string -> isBlank(string));
}

answered Jun 17, 2020 at 23:30

GedankenNebel

2,6375 gold badges32 silver badges40 bronze badges

Collectives™ on Stack Overflow

Android check if multiple strings are not empty

6 Answers 6

Comments

2 Comments

1 Comment

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

2 Comments

1 Comment

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related