error in a search function in javascript

Question

I am trying to return contact info for "steve", but codecademy is telling me that it is not returning correctly.

It looks like your search function doesn't return contact information for Steve.

I am not able to find any error in this code. Can you help me with finding any syntax or logical errors in the search function that you can see?

var friends = {
    bill: {
        firstName: "bill",
        lastName: "gates",
        number :21415,
        address: ["mcklsn", "wcnskln"]
    },
    Steve: {
        firstName: "bill",
        lastName: "gates",
        number: 21415,
        address: ["mcklsn", "wcnskln"]
    }
};

var list = function (friends)
{
    for (bill in friends)
        console.log(bill);

    for (steve in friends)
        console.log(steve);
};

var search = function(name)
{
    for (var i in friends)
    {
        if (friends[i].firstName === name)
        {
            console.log(friends[i]);
            return friends[i];
        }
        else
            console.log("contact doesn't exist!");
    } 
};

@Idos the compiler is saying "It looks like your search function doesn't return contact information for Steve.". really dn't know how to fix it?! — Kaushani Roy Chowdhury
– Kaushani Roy Chowdhury, Commented Jan 18, 2016 at 15:25
@Idos well i am learning js in codecademy and the error is shown exactly like this. it's unedited. — Kaushani Roy Chowdhury
– Kaushani Roy Chowdhury, Commented Jan 18, 2016 at 15:30
please accept the answer if it solved your question (by clicking the green check mark next to it). — Idos
– Idos, Commented Jan 21, 2016 at 8:19

Idos · Accepted Answer · 2016-01-18 15:38:01Z

1

You should really pay attention to what you are writing, don't Ctrl-C Ctrl-V everything blindly. You are not calling your friends in the correct names and I would be offended if someone did that to me. Heck, Steve Jobs would be furious if you called him Bill!

This should work:

var friends = {
    Bill: {
        firstName: "Bill",
        lastName: "Gates",
        number: 21415,
        address: ["mcklsn", "wcnskln"]
    },
    Steve: {
        firstName: "Steve",
        lastName: "Jobs",
        number: 21416,
        address: ["mcklsnn", "wcnsklnn"]
    }
};

search("Bill");
search("Steve");

edited Jan 18, 2016 at 15:38

answered Jan 18, 2016 at 15:31

Idos

15.3k14 gold badges63 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jimbo Jonny · Accepted Answer · 2016-01-18 15:31:23Z

0

Yah, because your Steve property object's firstName is set to "bill".

So that code, searching for a match to 'steve' on the firstName property will not find one...because there isn't one. Both of those object's have 'bill' as their firstName property.

answered Jan 18, 2016 at 15:31

Jimbo Jonny

3,5791 gold badge21 silver badges23 bronze badges

Collectives™ on Stack Overflow

error in a search function in javascript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related