Creating a string array to call later in C#

Question

Creating a remote installer application in C#. First, I am doing a ping check to make sure the computer is alive before i run the install on it. I am going to implement service checks later.

I need to create a string array that will be based on the ping status being a success (goodPing) and a failure (badPing), so I can use it in another foreach loop where the installs will run.

foreach (string singleComputer in computerArray)
        {
            // Ping all computers
            Ping ping = new Ping();
            PingReply pingresult = ping.Send(singleComputer);

            if (pingresult.Status.ToString() == "Success")
            {
               string[] goodPing = new string[] {"singleComputer"};
            }
            else if (pingresult.Status.ToString() != "Success")
            {
               string[] badPing = new string[] {"singleComputer"};
            }
        }

Basically, I am making sure the computer is pingable, separating the "good" and "bad" computers. computerArray is a string array created from a file.

This is what I want it to look like after I create the arrays:

foreach (string computer in goodPing)
{
     //run installation code here.
}

Obviously, I cannot call goodPing because it is created in an if statement. Please enlighten me on what I am doing wrong.

krivtom · Accepted Answer · 2016-01-23 07:21:49Z

2

You need to create you array once, before running the loop. The issue with arrays is that there is no easy way to change the size of the array, and you don't know in advance how many records in each array you will have. So I suggest using List<T> instead of arrays:

List<string> goodPing = new List<string>();
List<string> badPing = new List<string>();
Ping ping = new Ping();

foreach (string singleComputer in computerArray)
{
    // Ping all computers
    PingReply pingresult = ping.Send(singleComputer);

    if (pingresult.Status.ToString() == "Success")
    {
         goodPing.Add(singleComputer);
    }
    else if (pingresult.Status.ToString() != "Success")
    {
         badPing.Add(singleComputer);
    }
}

And now you can use the list of good pings to do what you need to do:

foreach (string computer in goodPing)
{
     //run installation code here.
}

answered Jan 23, 2016 at 7:21

krivtom

25k10 gold badges53 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Julian Johnson Over a year ago

Is there any downside to using this method? That you know of?

Julian Johnson Over a year ago

I appreciate the fast response.

krivtom Over a year ago

@JulianJohnson Not sure I understand the question about the downside. Do you mean downside of creating variables before the loop?

Julian Johnson Over a year ago

My apologies. i understand the use of a list now. If I were to use an array, I wouldn't know how many records I have until I ran the script, or applied a count to it. Thanks for your help.

Vahid · Accepted Answer · 2016-01-23 07:23:48Z

You need to use generic lists instead of arrays and you need to declare them before the for loop so they will be accessible after it.

List<string> goodPings = new List<string>();
List<string> badPings = new List<string>();
foreach (string singleComputer in computerArray)
        {
            // Ping all computers
            Ping ping = new Ping();
            PingReply pingresult = ping.Send(singleComputer);

            if (pingresult.Status.ToString() == "Success")
            {
               goodPings.Add(singleComputer); // and don't forget to use the variable singleComputer here, not the literal string "singleComputer".
            }
            else if (pingresult.Status.ToString() != "Success")
            {
               badPings.Add(singleComputer);
            }
        }

Collectives™ on Stack Overflow

Creating a string array to call later in C#

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related