PHP: Issue with while loop condition

Question

I have the following code, unfortunately it's looping infinity but I can't understand why :

$tot_age is set to 604245119

while ($tot_age > 536467742) {
        $tot_age - 31536000;
        if  ($tot_age < 536467742 ) {
            // do something
            break;
        }
    }

So what I'm attempting to here is the following. If $tot_age is greater than 17 years, iterate through the loop and minus 12 months from $tot_age. I'm then attempting to break out of the loop at the point which $tot_age is less than 17 years. I'll apply some logic here too.

Can anyone see an issue here? Thanks

You are not setting $tot_age - 31536000 here,you are just doing an operation in the air as it were.Change it to $tot_age=$tot_age - 31536000; — Mihai
– Mihai, Commented Jan 26, 2016 at 13:58
Ah, thank you. It's been so long since I've done even basic arithmetic in PHP I appear to have forgotten how. — Liam Fell
– Liam Fell, Commented Jan 26, 2016 at 14:00

Atif Tariq · Accepted Answer · 2016-01-26 14:01:51Z

5

Use it like this:

while ($tot_age > 536467742) {
        $tot_age = $tot_age - 31536000;
        if  ($tot_age < 536467742 ) {
            // do something
            break;
        }
    }

answered Jan 26, 2016 at 14:01

Atif Tariq

2,7701 gold badge31 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

MortenSickel · Accepted Answer · 2016-01-26 14:00:54Z

4

The 2nd line should read

$tot_age = $tot_age - 31536000;

answered Jan 26, 2016 at 14:00

MortenSickel

2,2095 gold badges27 silver badges48 bronze badges

Comments

Martin_83 · Accepted Answer · 2016-01-26 14:05:48Z

4

Youre not changing the value of tot_age in the loop, you're just making an empty statement. Change:

$tot_age - 31536000;

to:

$tot_age = $tot_age - 31536000;

answered Jan 26, 2016 at 14:05

Martin_83

516 bronze badges

Collectives™ on Stack Overflow

PHP: Issue with while loop condition

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related