PHP: call a string from another page function?

Question

Can you do that? I just tried but it doesnt seem to work.

I have dbc.php included at top of my page, and in dbc.php at the bottom i created this function:

function getUserInfo($id) {
$thaString = mysql_query("SELECT * FROM users WHERE id = '$id'");
$thaString2 = mysql_query("SELECT * FROM users_profile WHERE uID = '$id'");
$showUR = mysql_fetch_array($thaString);
$showURP = mysql_fetch_array($thaString2);
}

So it would be easier for me to call them instead of running the queries all the time when i need them in other pages.. But when i try to do:

getUserInfo($showInfo["bID"]);
echo $showUR["full_name"];

I dont get any result, is there a smarter way to do this, if so how?

score 2 · Accepted Answer · 2010-08-22 12:28:31Z

2

It's an issue of scope: $showUR is set inside getUserInfo(), so it's not available to the echo outside the function. There are lots of potential modifications you could make, but you may want to assign your values into an array and then return that array:

function getUserInfo($id) {
    $user = array();

    $thaString = mysql_query("SELECT * FROM users WHERE id = '$id'");
    $thaString2 = mysql_query("SELECT * FROM users_profile WHERE uID = '$id'");
    $user['showUR'] = mysql_fetch_array($thaString);
    $user['showURP'] = mysql_fetch_array($thaString2);

    return $user;
}

$user = getUserInfo($showInfo["bID"]);
echo $user['showUR']["full_name"];

edited Aug 22, 2010 at 12:28

answered Aug 20, 2010 at 22:59

user7675

Sign up to request clarification or add additional context in comments.

Comments

NullUserException · Accepted Answer · 2010-08-20 23:30:46Z

1

Your functions have to return something for the values to be used, or $showUR and $showURP will just get lost once the function exits (ie: the scope will change). Something like:

function someFunc($arg) {
    return "Hello, I am {$arg}";
}

$showUR = someFunc('name');
echo $showUR;

And please don't call stuff $thaString. First because it's a misnomer (mysql_query() doesn't return a string, it returns a resource or a boolean), Second because "tha" is so lame.

edited Aug 20, 2010 at 23:30

answered Aug 20, 2010 at 22:56

NullUserException

85.8k31 gold badges212 silver badges239 bronze badges

Comments

Ikke · Accepted Answer · 2010-08-20 22:57:53Z

0

Let your function return the variable.

And then use $showUR = getUserInfo(...)

answered Aug 20, 2010 at 22:57

Ikke

102k23 gold badges101 silver badges121 bronze badges

Comments

Josh · Accepted Answer · 2010-08-20 23:00:42Z

0

If you declare them outside the function, and then as globals inside the function you should be able to use them as you are now.

answered Aug 20, 2010 at 23:00

Josh

1,8043 gold badges17 silver badges31 bronze badges

Collectives™ on Stack Overflow

PHP: call a string from another page function?

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related