Mysql fetch array error

Question

Im getting an error on my site that appeared for the first time today, despite functioning fine for months.

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /web_directory/index.php on line 33

Here is the code from those lines.

<?  $sql = "SELECT 
            p.id as 'id',
            p.post_title as 'client',
            (SELECT `meta_value` FROM `wp_postmeta` WHERE `post_id` = p.id AND `meta_key` = 'thumb1') as 'thumb'
            FROM
            `wp_posts` p
            INNER JOIN `wp_postmeta` pm ON (p.id = pm.post_id)
            INNER JOIN `wp_term_relationships` wtr ON (p.id = wtr.object_id)
            INNER JOIN `wp_term_taxonomy` tt ON (wtr.term_taxonomy_id = tt.term_taxonomy_id)
            WHERE 
            tt.term_id = 439
            AND tt.taxonomy = 'category'
            AND p.post_status = 'publish'
            GROUP BY p.id
            ORDER BY p.id DESC
            LIMIT 5
            ";
    $sql = mysql_query($sql);
    $i=0;
    while($s = mysql_fetch_array($sql))
    {
        $i++;
?>

Im not the original developer of the site, and I dont have much of a knowledge with mysql. Thanks for your awesome answers in advance!

You should really consider using PDO or mysqli instead of the mysql extension. — Lèse majesté
– Lèse majesté, Commented Aug 21, 2010 at 23:27
I'm guessing that line 33 is while($s = mysql_fetch_array($sql))? Could you fill in the rest of the while loop? — Jeffrey Blake
– Jeffrey Blake, Commented Aug 21, 2010 at 23:27

Sarfraz · Accepted Answer · 2010-08-21 23:42:22Z

1

There might be some error in your query; try adding or die(mysql_error()) to mysql_query like this:

$sql = mysql_query($sql) or die(mysql_error());

The mysql_query should return a resource identifier which you can check with:

if (!is_resource($sql)){
  die(mysql_error());
}

answered Aug 21, 2010 at 23:42

Sarfraz

384k81 gold badges561 silver badges613 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

nicomen · Accepted Answer · 2010-08-21 23:43:24Z

Obviously you are feeding mysql_fetch_array() not a valid MySQL result resource.

This might happen whenever mysql_query fails for any reason. (query is wrong, database has gone away, network is down, etc etc.)

You should check if a call to mysql_query is successfull before trying to iterate over its data. If you add a check and print out what the error really is, you might pin it down yourself.

For SELECT, SHOW, DESCRIBE, EXPLAIN and other statements returning resultset, mysql_query() returns a resource on success, or FALSE on error.

http://php.net/manual/en/function.mysql-query.php

Adding this before mysql_fetch_array() will make sure the script dies whenever an error has occurred including the actual error message:

$res = mysql_query($sql);
if (!$res) {
    die('Invalid query: ' . mysql_error());
}

Collectives™ on Stack Overflow

Mysql fetch array error

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related