AngularJS: Method expression is not of Function type

Question

Having a class defined as:

angular.module('trip')
        /** @class MyClass */
        .factory('MyClass', [Factory]);

function Factory() {
   return function(){
         // fields & functions
   }
}

Then in the code I would instantiate a new object:

/**
 * @param {MyClass} MyClass
 */
function(MyClass){
   var myClass = new MyClass(); // HERE MyClass is highlighted in phpStorm
}

When calling new MyClass(); the MyClass is highlighted in phpStorm and I get this warning:

Method expression is not of Function type

What does it mean? How to get rid of it?

A very similar question was asked here without any comment either: stackoverflow.com/q/32778278/1075289 — Amio.io
– Amio.io, Commented May 18, 2016 at 10:47
@GrahamPHeath The brackets are there because we use strict DI. So it ain't change anything. — Amio.io
– Amio.io, Commented May 19, 2016 at 6:15

de1mar · Accepted Answer · 2016-05-19 10:15:10Z

10

WebStorm (along with other tools) understands /** @param {MyClass} MyClass */ as a declaration of an instance of MyClass. It says you can't instantiate an instance. I may only suggest to change JSDoc to /** @param {function():MyClass} MyClass */ to cease the warning. JSDoc itself doesn't offer a better way to express a factory.

Also, please take a look at https://youtrack.jetbrains.com/issue/WEB-17325.

answered May 19, 2016 at 10:15

de1mar

1,21611 silver badges6 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Amio.io Over a year ago

Thx @de1mar, it's suppressing the warning and that's what I needed.

Dmitry Kurowsky Over a year ago

This answer is relevant for PhpStorm 2022.3 too, thanks!

Collectives™ on Stack Overflow

AngularJS: Method expression is not of Function type

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related