Change inline JS to click function in jQuery

Question

Trying to clean up some code. I have a button that has the following inline JS

<input id="lookup" type="submit" name="lookup" value="Search" onclick="changestart('1')" />

I would like to change the onclick to a jQuery click funnction but am getting no success. Here is the "changestart" function

function changestart(direction) {
    var rowsElement  = $("#maxrows");
    var rowsValue    = parseInt(rowsElement.val());
    var startElement = $("#startID");
    var value        = parseInt(startElement.val());
    startElement.val(direction == "forward" ? value + rowsValue : direction == "back" ? value - rowsValue : 1);
}

$("#previous").click(function(){changestart('back');});
$("#next").click(function(){changestart('forward');});

I've tried

$("#lookup").click(function(){changestart.val(1);});

but it doesn't work.

what is it that you are trying to accomplish with the button ? — bevacqua
– bevacqua, Commented Sep 20, 2010 at 13:21

Nick Craver · Accepted Answer · 2010-09-20 13:21:49Z

2

Since your code defaults down to 1 anyway, you can just do this:

$("#lookup").click(changestart);

There's no .val() method on functions, and the argument you're passing doesn't matter anyway, anything except "forward" and "back" are 1, so you can pass with no argument as well, which is what the above code does.

answered Sep 20, 2010 at 13:21

Nick Craver

631k138 gold badges1.3k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Dirty Bird Design Over a year ago

so the other answers also work, but yours is even shorter. Awesome. Thanks Nick!

Pim Jager · Accepted Answer · 2010-09-20 13:20:15Z

1

Don't you just mean:

$("#lookup").click(function(){changestart(1);});

answered Sep 20, 2010 at 13:20

Pim Jager

32.2k17 gold badges75 silver badges100 bronze badges

1 Comment

Dirty Bird Design Over a year ago

and @JamesStuddart - thanks guys, this works. I did not know that when setting value for a function you don't need .val(). I have a lot to learn, thanks for your help

mkoistinen · Accepted Answer · 2010-09-20 13:20:17Z

1

$("#lookup").click(function(){ changestart(1); });

answered Sep 20, 2010 at 13:20

mkoistinen

7,7943 gold badges45 silver badges58 bronze badges

2 Comments

Dirty Bird Design Over a year ago

thank you. so when you are setting a value for a function you do not use .val? Learned something, thank you sir!

mkoistinen Over a year ago

Nope. val() is used for getting/setting the value of a form element. For example, $('form select').val() would provide the value of the option that the select element is currently set to. Similarly, $('form select').val(5) would set it to the option with a value of 5. Also works with other form elements like checkboxes, radio buttons, input fields & textfields (did I leave any out?). Glad I could help!

JamesStuddart · Accepted Answer · 2010-09-20 13:20:46Z

1

Ensure the javascript is either under the button in the markup OR use:

$(document).ready(function(){
    $("#lookup").click(function(){changestart(1);});
});

answered Sep 20, 2010 at 13:20

JamesStuddart

2,6313 gold badges28 silver badges45 bronze badges

Comments

Pramendra Gupta · Accepted Answer · 2010-09-20 13:22:08Z

0

Try this

<input id="lookup" type="submit" name="lookup" value="Search" onclick="changestart('1')" />

to

<input id="lookup" type="submit" name="lookup" value="Search"/>

and

$("#lookup").click(function(){changestart.val(1);});

to

$("#lookup").click(function(){changestart(1);});

answered Sep 20, 2010 at 13:22

Pramendra Gupta

14.9k4 gold badges35 silver badges35 bronze badges

Collectives™ on Stack Overflow

Change inline JS to click function in jQuery

5 Answers 5

1 Comment

1 Comment

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

1 Comment

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related