Escaping a double-quote in inline c# script within javascript

Question

I need to escape a double quote in inline c# within javascript. Code is below:

if ("<%= TempData["Message"]%>" == "") {
    // code
};

Normally, I would just use single quotes like so:

if ('<%= TempData["Message"]%>' == "") {
    // code
};

However, TempData["Message"] has single quotes within it (when it contains a link generated by the Html.ActionLink() helper in ASP.NET MVC). So while I could change all the ActionLink helpers inside TempData["Message"] to tags, it's an interesting problem and would been keen to hear if anyone has an answer.

SLaks · Accepted Answer · 2010-09-21 23:05:42Z

9

Call HttpUtility.JavaScriptStringEncode.
This method is new to ASP.Net 4.0; for earlier versions, use the WPL.

answered Sep 21, 2010 at 23:05

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

ajbeaven Over a year ago

Hmm, I don't have .NET 4. What does it do?

SLaks Over a year ago

It escapes a bunch of characters. Use WPL.

Chris Fulstow · Accepted Answer · 2011-09-20 00:16:26Z

2

You can use the AjaxHelper.JavaScriptStringEncode method inside a Razor view, like this:

if ("@Ajax.JavaScriptStringEncode(TempData["Message"].ToString())" == "") {
    // do stuff
}

If that's too verbose, create this little helper in /App_Code/JS.cshtml

@helper Encode(string value) {
    @(HttpUtility.JavaScriptStringEncode(value))
}

Which you can then call from any view:

@JS.Encode("'single these quotes are encoded'")

answered Sep 20, 2011 at 0:16

Chris Fulstow

42k10 gold badges91 silver badges114 bronze badges

Comments

Clicktricity · Accepted Answer · 2010-09-21 23:08:35Z

0

I have addressed this by writing a HtmlHelper that encodes the strings to a format acceptable in Javascript:

public static string JSEncode(this HtmlHelper htmlHelper, string source)
{
    return (source ?? "").Replace(@"'", @"\'").Replace(@"""", @"\""").Replace(@"&", @"\&").Replace(((char)10).ToString(), "<br />");
}

Then, in your view:

if ('<%= Html.JSEncode( TempData["Message"] ) %>' == "") {
    // code
};

answered Sep 21, 2010 at 23:08

Clicktricity

4,2091 gold badge25 silver badges15 bronze badges

3 Comments

SLaks Over a year ago

That's very wrong. You should not be replacing \r with <br /> tags, and there are more characters that you need to escape.

bobince Over a year ago

Specifically: backslash itself (otherwise \" is escaped to \\" and breaks the string with security implications) and other newline characters.

Clicktricity Over a year ago

This is what works for me, and the messages I need to encode. Feel free to adjust to your individual needs

Collectives™ on Stack Overflow

Escaping a double-quote in inline c# script within javascript

3 Answers 3

2 Comments

Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related