PHP IF Statement executing both conditions

Question

I'm currently integrating a payment system into my website. I have a response script which basically takes in the data from the secure server and displays to the customer if the payment has gone through or not. My problem is that the if statement is actually displaying both messages to the customer, even if the payment has been successful or unsuccessful.

Here is the If statement:

<?
if ($result == "00") && ($payersetup == "00") && ($pmtsetup =="00"){
?>  
Thank you
<br/><br/>
To return to the home page <a href="http://www.xx.com"><b><u>click here</u></b></a>
<br/><br/>

<?
} else {
?>

<br/><br/>
There was an error processing your subscription.  
To try again please <a href="http://www.xx.com/signUp.html"><b><u>click here</u></b></a><br><BR>
Please contact our customer care department at <a href="mailto:[email protected]"><b><u>[email protected]</u></b></a>

<?
}
?>

I have also tried doing this the following way, however with this method, the body is blank - no text is displayed.

<?
if ($result == "00") && ($payersetup == "00") && ($pmtsetup =="00"){
$thanks = "Thank you! \n\n To Return to the homepage <a href=http://www.epubdirect.com>Click Here</a>"; 
echo $thanks;
} 
else 
{
$nothanks = "There was an error processing your subscription.\n\n To try again please <a href=http://www.epubdirect.com/signUp.html>click here</a>. \n\n If the problem persists, please contact our customer care department at <a href=mailto:[email protected]>[email protected]</a>";
echo $nothanks;
}
?>

And after that I tried to put the HTML into a seperate document and use require_once() but this didn't work either - same result as previous - blank body.

Any one have any ideas?

EDIT:

I have tried some of the ways suggested however I'm still having the blank page problem :(

Here is the way I have gone ->

<?
if (($result == "00") && ($payersetup == "00") && ($pmtsetup =="00"))
{
require_once('thankyou.html');
} 
else 
{
require_once('error.html');
}
?>

This still gives me a blank page even though the syntax looks right?

If you're getting a blank page, it's probably throwing syntax errors but not displaying them. Try turning error reporting on in your php.ini (or else check your server logs for PHP errors). — Spudley
– Spudley, Commented Sep 22, 2010 at 13:21
Configure your error reporting to show you errors and warnings: php.net/manual/en/function.error-reporting.php — Brendan Bullen
– Brendan Bullen, Commented Sep 22, 2010 at 13:37

sdot257 · Accepted Answer · 2010-09-22 13:05:23Z

10

Try:

if (($result == "00") && ($payersetup == "00") && ($pmtsetup =="00") ) {
   ...
   ...
}

answered Sep 22, 2010 at 13:05

sdot257

10.4k27 gold badges95 silver badges128 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Skilldrick Over a year ago

Yes, I think the missing parentheses are the problem.

codaddict · Accepted Answer · 2010-09-22 13:09:54Z

9

To add to others answers:

Your original code:

if ($result == "00") && ($payersetup == "00") && ($pmtsetup =="00")

is a syntax error. Once the PHP parser sees ) which marks the end of the if conditional it expects to see another statement(s) or a { to mark the beginning of if body. But when it sees && it throws this syntax error:

PHP Parse error:  syntax error, unexpected T_BOOLEAN_AND

I think you've disabled your error reporting thats why you are seeing a blank page.

answered Sep 22, 2010 at 13:09

codaddict

457k83 gold badges501 silver badges537 bronze badges

3 Comments

Andrew Over a year ago

Moral of the story: Turn on all error reporting during development.

109221793 Over a year ago

@Andrew - how to I turn on error reporting? I am working on a server I did not set up.

Brendan Bullen Over a year ago

@TaraWalsh You can set error reporting in the script using the error_reporting() function: php.net/manual/en/function.error-reporting.php

Sarfraz · Accepted Answer · 2010-09-22 13:06:33Z

3

I wonder how your condition is run at all because you have ( and ) missing in your if conditions:

if (($result == "00") && ($payersetup == "00") && ($pmtsetup =="00")){...}

Or simply:

if ($result == "00" && $payersetup == "00" && $pmtsetup =="00"){...}

answered Sep 22, 2010 at 13:06

Sarfraz

384k81 gold badges561 silver badges613 bronze badges

Comments

deceze · Accepted Answer · 2010-09-22 13:05:30Z

2

You probably mean:

if ($result == "00" && $payersetup == "00" && $pmtsetup == "00") {

The if ends after the closing ).

answered Sep 22, 2010 at 13:05

deceze♦

525k89 gold badges806 silver badges954 bronze badges

Comments

Pramendra Gupta · Accepted Answer · 2010-09-22 13:09:17Z

2

Simple clean way

<? if (($result == "00") && ($payersetup == "00") && ($pmtsetup =="00")):?>
 Thank you
 <br/><br/>
 To return to the home page <a href="http://www.xx.com"><b><u>click here</u></b></a>
 <br/><br/>
<?php else : ?>
 <br/><br/>
 There was an error processing your subscription.  
 To try again please <a href="http://www.xx.com/signUp.html"><b><u>click      here</u></b></a><br><BR>
 Please contact our customer care department at <a  href="mailto:[email protected]"><b><u>[email protected]</u></b></a>
<?php endif ?>

answered Sep 22, 2010 at 13:09

Pramendra Gupta

14.9k4 gold badges35 silver badges35 bronze badges

2 Comments

user229044 Over a year ago

I'd voted it down (hastily, which I undid) because it's a bad answer. All you did was rewrite the original code in your own style with no justification of why it's better and no explanation of what was wrong in the first place. How is anybody supposed to learn from this?

Pramendra Gupta Over a year ago

thanks for highliting , Problem is with if as every one knows out of it. if you see all answers in this post , you will find i am using if(): which gives a clean way to embed in html. this is alternative of all other answer.

Chris Frederick · Accepted Answer · 2011-08-30 21:30:15Z

2

Here is what you have to do to turn error reporting on:

In your PHP-script: Use the function error_reporting, described here.

Or, if you have acces to your php.ini, refer to this document.

You should use a local development server (like XAMPP on Windows/Linux) on your own computer and when you are done deploy on the real server.

edited Aug 30, 2011 at 21:30

Chris Frederick

5,5943 gold badges38 silver badges44 bronze badges

answered Sep 22, 2010 at 13:37

ThE_-_BliZZarD

7742 gold badges12 silver badges28 bronze badges

Comments

Ryan Chouinard · Accepted Answer · 2010-09-22 13:59:23Z

As others have pointed out, you need to wrap multiple conditions in your if statement in parentheses:

if (($cond1) && ($cond2)) { ... }

Failure to do so will cause a fatal parse error.

HOWEVER, if this was the root cause of the problem, execution of the page would stop on that line, and render either a PHP error to the browser or a blank page. The original post indicates that this isn't what happens; instead, both HTML blocks are output.

Have you viewed the source in your browser to see if there is anything sent to the browser? I half suspect that you're using short open tags (given, since you use them in the code block), and your PHP config is set to disallow them. This would cause the entire code block to be sent as-is to the browser, which means that the fatal parse error is never triggered, and the browser treats the <? ... ?> block as invalid HTML and simply ignores it. This causes both HTML blocks to render as described.

Of course, if short open tags are enabled, I have no idea. :-)

Collectives™ on Stack Overflow

PHP IF Statement executing both conditions

7 Answers 7

1 Comment

3 Comments

Comments

Comments

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

1 Comment

3 Comments

Comments

Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related