PHP echo javascript to change iframe source

Question

I have a text input search form for support tickets. If the user inputs a ticket id (checked using a PHP if statement), the background color of the search box is changed to yellow (using a PHP echo) to highlight the search text entered. This part works.

I would like to also change the source value of an iframe as part of the PHP if condition like this:

    <td align="left">
        <input type="text" name="ticket" id="ticket" placeholder="Ticket" value="<?php echo $this->state->ticket;?>" class="input-mini search-query" onchange="document.adminForm.submit();"
        <?php if ($this->state->ticket != "")
            {
            echo 'style="background-color: yellow;"';
            echo '<script language="javascript">';
            echo 'document.getElementById("ticketIframe").contentWindow.document.location.href="http://myurl.com"';
            echo '</script>';       
            }?>/>
    </td>

The javascript function (document.getElementById...) displays on the page rather than executing. I tried a simple javascript alert, but got the same result.

Suggestions?

id say the poor browser gave up trying to correct the code. Close your input > — David
– David, Commented Jun 26, 2016 at 0:55

charlietfl · Accepted Answer · 2016-06-26 00:59:35Z

2

Need to close the input tag before you insert script tag. You simply are generating invalid html that looks like:

<input <script></script> />

You get unexpected results when html is invalid

edited Jun 26, 2016 at 0:59

answered Jun 26, 2016 at 0:56

charlietfl

172k14 gold badges125 silver badges154 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

user557846 Over a year ago

thats not valid html

charlietfl Over a year ago

@Dagon isn't that what i said?

user557846 Over a year ago

sorry, i thought that was what you suggested changing it to

JohnT Over a year ago

Closing the input made a javascript alert work properly, thank you, but my iframe source is still not working. Ideas?

charlietfl Over a year ago

Is the iframe src on same domain as page? Would throw error in your console if it isn't. If all you want is to change url....change the actual iframe element src instead of trying to go inside it

|

Collectives™ on Stack Overflow

PHP echo javascript to change iframe source

1 Answer 1

9 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

9 Comments

Your Answer

Sign up or log in

Post as a guest

Related