Spring MVC: correct exception handling

Question

I am wondering how to bind exception handling method to url mapping method:

@Controller
public class UserController {

    @Autowired
    UserDao userDao;

    @RequestMapping(value = "/user", method = RequestMethod.GET)
    public String users(@ModelAttribute("model") ModelMap model) {
        model.addAttribute("userList", userDao.getAll());
        String[] b = new String[0];
        String a = b[1];
        return "user";
    }

    @ExceptionHandler(Exception.class)
    public String handleAllException(Exception ex, @ModelAttribute("model") ModelMap model) {
        model.addAttribute("error", "Exception happened");
        return "error_screen";
    }
}

I intentionally provoke java.lang.ArrayIndexOutOfBoundsException in users method. But I see that handleAllException method wasn't executed.

Question: What have I forgotten to get done to make Exception Handling work appropriately?

I think that you try to use annotation @ModelAttribute incorrectly. Please try something like that: ` @ExceptionHandler(Exception.class) public ModelAndView handleError(Exception exception) { //Code here return new ModelAndView("error"); }` — NguaCon
– NguaCon, Commented Jul 18, 2016 at 10:05

Maksim Prabarshchuk · Accepted Answer · 2016-07-18 10:08:02Z

1

Try to do somedthing like this:

 @ExceptionHandler(Exception.class)
 public ModelAndView handleAllException(Exception ex) {
  ModelAndView model = new ModelAndView("error_screen");
  model.addAttribute("error", "Exception happened");
  return model;
 }

answered Jul 18, 2016 at 10:08

Maksim Prabarshchuk

5001 gold badge3 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Niku Hysa · Accepted Answer · 2016-07-18 09:55:41Z

0

Try the following

@ExceptionHandler(Exception.class) -> @ExceptionHandler({Exception.class})

answered Jul 18, 2016 at 9:55

Niku Hysa

762 silver badges12 bronze badges

1 Comment

rajadilipkolli Over a year ago

This array declaration is not necessary, its needed only when we have more that one exception class

Vasu · Accepted Answer · 2016-07-18 09:55:47Z

0

The reason is it has failed with the below exception while trying to invoke the handleAllException() method:

DEBUG [http-nio-8080-exec-6] --- ExceptionHandlerExceptionResolver: Failed to invoke @ExceptionHandler method: public java.lang.String controllers.handleAllException(java.lang.Exception,org.springframework.ui.ModelMap) java.lang.IllegalStateException: No suitable resolver for argument [1] [type=org.springframework.ui.ModelMap] HandlerMethod details:

Change the Method as below:

@ExceptionHandler(Exception.class)
    public String handleAllException(Exception ex) {
        // model.addAttribute("error", String.format("Exception happened"));
        return "error_screen";
    }

answered Jul 18, 2016 at 9:55

Vasu

22.6k11 gold badges54 silver badges71 bronze badges

Collectives™ on Stack Overflow

Spring MVC: correct exception handling

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related