AngularJS : Getting Error on adding $scope in factory-service

Question

studentService.js

   app.factory('saveStudentService',['$http','$scope',function ($http,$scope) { 
            var studentData = {};
            studentData.save = function(jsondata){
                var action = "student";
                var method = "POST";
                $http({
                    url: action,
                    method: method,
                    headers: {'Content-Type': 'application/json'},
                    data: jsondata
                }).success(function(data, status, headers, config) {
                    toastr.success(status +' : Data has been submitted successfully ');
                }).error(function(data, status, headers, config) {
                    toastr.error(status + ' : Data has not been submitted successfully ');
                });
            };
            return studentData;
        }]);

I am getting this error

angular.js:13642Error: [$injector:unpr] http://errors.angularjs.org/1.5.6/$injector/unpr?p0=%24scopeProvider%20%3C-%20%24scope%20%3C-%20saveStudentService
    at Error (native)
    at https://ajax.googleapis.com/ajax/libs/angularjs/1.5.6/angular.min.js:6:412

If from studentService.js, $scope is being removed, i.e

app.factory('saveStudentService',['$http',function ($http) {

this code is working properly, and not getting any error message in console.

Following is the studentController.js file from where this studentService is being called.

StudentController.js

app.controller('saveStudentCtrl',['$scope', 'saveStudentService', function($scope,saveStudentService) { 
    $scope.submit_create_student = function() {
        var jsondata = $scope.student;
        saveStudentService.save(jsondata);
    }

}]);

but if same thing i.e $scope is being added in the updateStudentService then this code is working as expected.

app.controller('updateStudentCtrl',['$scope','retriveStudentService', 'updateStudentService', function($scope,retriveStudentService, updateStudentService) {    
    $scope.getStudentDataFromServer = function() {      
        retriveStudentService.get();
    };
    $scope.submit_update_student = function(e) {
        updateStudentService.update();
    }

}]);

Could someone please clarify, what is happening here. Though able to use same thing in one place, but not able to use same process at someother place.

Possible duplicate of Accessing $scope in AngularJS factory? — Clint
– Clint, Commented Aug 28, 2016 at 17:26
you mean to say in studentController.js and studentService.js ? — Noorus Khan
– Noorus Khan, Commented Aug 28, 2016 at 17:29
But why do you need $scope in factory? IMO there is something wrong in design if you need scope in your factory/service — Developer
– Developer, Commented Aug 28, 2016 at 17:32

user2009750 · Accepted Answer · 2016-08-28 17:39:36Z

5

You cannot inject scope into services. You can inject it to controllers.

edited Aug 28, 2016 at 17:39

answered Aug 28, 2016 at 17:33

user2009750

3,1976 gold badges37 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Noorus Khan Over a year ago

hey thanks for your comment. I have just started working with angularjs.

Noorus Khan Over a year ago

from my code if you find something else that need to be rectified, please let me know.. thanks

user2009750 Over a year ago

Your code looks good, try using $resource instead of $http when possible.

plong0 Over a year ago

Yes, you don't inject $scope into services. Sometimes you would inject $rootScope into a service if for example it needs to broadcast system-wide events. Services are designed to be global objects, while $scope is designed to hold contextual data.

Collectives™ on Stack Overflow

AngularJS : Getting Error on adding $scope in factory-service

1 Answer 1

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related