Finding Item in JSON Array and adding it to another Array. Javascript

Question

Having some issues with finding an item in a JSON Array and passing it to a different array. The error I am getting appears to be that it's not properly passing the item out of the function. It is finding the item in the database, I can see it properly in console logs and view it properly with JSON.stringify.

Though, no matter how I have tried passing it out of the function (as a string, as an object etc.) it is not returning a value besides undefined.

If I do a console.log on newCard it will always come back as undefined.

Any help on this would be greatly appreciated, thank you.

var deckObject = [];
var newCard = findCard('EX1_123');
deckObject.push(newCard);

function findCard(cardId){
   $.each(cardDB, function(i, v) {
      if (v.id === cardId) {    
         v['count'] = 1;
         return v;
      }
    });

}

A.T. · Accepted Answer · 2016-09-19 04:26:17Z

1

you should never return value from loop, rather use callback to manage asynchronous code

var deckObject = [];
var newCard = findCard('EX1_123',function(newcard){
  deckObject.push(newCard);
});

function findCard(cardId,callback){
   $.each(cardDB, function(i, v) {
      if (v.id === cardId) {    
         v['count'] = 1;
         callback(v);
      }
    });
}

answered Sep 19, 2016 at 4:26

A.T.

26.7k8 gold badges50 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Shubham Khatri · Accepted Answer · 2016-09-19 04:32:09Z

$.each doesn't return out of the function. Assign the returned value to a vraible and then return it.

function findCard(cardId){

   var res = $.each(cardDB, function(i, v) {

      if (v.id === cardId) { 
         console.log(v.id);
         v['count'] = 1;
         return v;
      }
    });
  return res;

}

Sample Snippet.

$(function(){
var cardDB = [
{
	id: '1',
  count: 0
},
{
	id: '2',
  count: 0
},
{
	id: '3',
  count: 0
}

]
var deckObject = [];
var newCard = findCard('1');
console.log(newCard);
deckObject.push(newCard);

function findCard(cardId){
   
   var opt = $.each(cardDB, function(i, v) {
     
      if (v.id === cardId) { 
         console.log(v.id);
         v['count'] = 1;
         return v;
      }
    });
  return opt;

}

})

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>

Collectives™ on Stack Overflow

Finding Item in JSON Array and adding it to another Array. Javascript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related