Adding Integers to an Array in Java

Question

I have to create a program that accepts user input of numbers and then adds them to an ArrayList and then manipulates the data in several ways. The numbers must greater than or equal to 0. I am having an issue with adding the user input to the ArrayList, my try and catch statements stop the program from crashing but I can't add anything to the ArrayList, can someone tell me what I'm doing wrong in my adding process? Here's my code:

import java.util.ArrayList;
import java.util.Collections;

public class SumElements extends javax.swing.JFrame {
ArrayList <Integer> values = new ArrayList();

...

private void addButtonActionPerformed(java.awt.event.ActionEvent evt) {                                          
    try
    {

        //clear outputArea
        outputArea.setText(null);
        valueInput.setText(null);
        outputLabel.setText(null);

        //declare variables
        int value = Integer.parseInt(valueInput.getText());

        //validate input
        if (value >= 0){
            //add item to array
            values.add(value);

            //display values
            Collections.sort(values);
            for (int i = 0; i < values.size(); i++)
            {
                outputArea.setText(outputArea.getText() + values.get(i) + "\n");
            }
        }
    }
    //set default
    catch (NumberFormatException a)
    {
     outputLabel.setText("Please input a valid number.");
    }
}

you are first setting the text of valueInput to null and then reading it - what did you expect to be the result? — UnholySheep
– UnholySheep, Commented Oct 4, 2016 at 19:22

Nicolas Filotto · Accepted Answer · 2016-10-04 19:27:05Z

5

This is because you set the text of valueInput to null (with valueInput.setText(null)) before calling Integer.parseInt(valueInput.getText()) which will throw a NumberFormatException of the following type:

Exception in thread "main" java.lang.NumberFormatException: null
    at java.lang.Integer.parseInt(Integer.java:542)
    at java.lang.Integer.parseInt(Integer.java:615)

So simply remove the line valueInput.setText(null);

answered Oct 4, 2016 at 19:27

Nicolas Filotto

45.2k11 gold badges97 silver badges129 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Wojtek · Accepted Answer · 2016-10-04 20:07:05Z

0

You can parse only those strings, which represents numbers. The String variable which is pointing to null is definitely not representing the number. What I would suggest is to modify the code in this way:

    //declare variables
    int value = Integer.parseInt(valueInput.getText());

    //clear outputArea
    valueInput.setText("");
    outputLabel.setText("");

    //validate input
    if (value >= 0){
        //add item to array
        values.add(value);

        //display values
        Collections.sort(values);
        for (int i = 0; i < values.size(); i++) {
            outputArea.setText(outputArea.getText() + values.get(i) + "\n");
        }

answered Oct 4, 2016 at 20:07

Wojtek

1,30811 silver badges18 bronze badges

Comments

Ilgorbek Kuchkarov · Accepted Answer · 2016-10-04 22:16:52Z

0

Do //clear outputArea after you are done parsing the input and saving them into variables!

answered Oct 4, 2016 at 22:16

Ilgorbek Kuchkarov

957 bronze badges

Collectives™ on Stack Overflow

Adding Integers to an Array in Java

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related