C Struct typedef and declaration causing pointer errors

Question

I've tried and distill the following code as much as possible:

#include <stdlib.h>

typedef struct item{
    struct item *next;
}item;

void addItem(item *list)
{
    item *newItem = list;
    while(newItem->next != NULL){
        newItem = newItem->next;
    }

    newItem->next = malloc(sizeof(item));
    newItem->next->next = NULL;
}

int main()
{
    item *groceryList = NULL;
    groceryList = malloc(sizeof(item));
    if(groceryList == NULL)
        return 1;
    groceryList->next = NULL;

    addItem(groceryList);

    return 0;
}

This compiles fine. But changing the struct declaration to (or any combination of the changes):

typedef struct{ /*Removed "item"*/
    item *next; /*Removed "struct"*/
}item;

Causes the following errors when compiling:

structpointertest.c:11:11: warning: assignment from incompatible pointer type structpointertest.c:15:15: error: request for member 'next' in something not a structure or union

I don't understand what in the struct declaration is causing this issue? Does it have something to do with the fact I'm using a nested struct?

Thanks.

The compiler doesn't know what item is at the declaration line item *next. — barak manos
– barak manos, Commented Oct 13, 2016 at 15:16
There is no "nested structure". And there cannot be without endless recursion. — too honest for this site
– too honest for this site, Commented Oct 13, 2016 at 15:19
Sorry, I worded it badly. I didn't mean a nesting of structures, but rather a nesting of aliases. — Simon Storfors
– Simon Storfors, Commented Oct 13, 2016 at 15:57

Some programmer dude · Accepted Answer · 2016-10-13 15:21:02Z

4

In C you must declare things before you can use them. When you do

typedef struct item { ... }

the struct item part is a declaration telling the compiler that there exists a structure name item. That means you could use it later, even inside the structure to define a pointer to itself.

When you do

typedef struct { ... } item;

you are not giving the structure a name, and the type-alias item is declared after the structure, so it can't be used inside the structure.

The simple solution is to use the first way. Another solution is to declare the type-alias before the structure, like

typedef struct item item;
struct item
{
    item *next;  // Can use type-alias, as it has been declared up above
};

Either way, you must still give the structure itself a name.

Also note that struct item *next; (or item *next;) declares a member variable that is a pointer to the structure, it's not the actual structure itself nested recursively. Creating a pointer to something that haven't been fully defined yet is okay.

answered Oct 13, 2016 at 15:21

Some programmer dude

411k36 gold badges420 silver badges655 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Simon Storfors Over a year ago

Your last paragraph was bad wording by me.

Simon Storfors Over a year ago

Gah, new to the site, Enter in a comment is bad! Anyway, Thank you. I see now in what order the typedef is defined.

JoulinRouge Over a year ago

+1 because i tried to create a pointer to something that haven't been fully defined yet ... and surprisingly it works! I didn't know that

Paul Ogilvie Over a year ago

Best/easiest ways is typedef struct ITEM {...} item; (Use capitals in the struct tag namespace to distinguish from typedef namespace.)

Collectives™ on Stack Overflow

C Struct typedef and declaration causing pointer errors

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related