Button onclick event is not calling javascript function in php

Question

I'm calling a javascript function in php. it works when i call alert() method directly on click. here is my code

echo "<form action='' method='post' enctype='multipart/form-data' >
          <div class='fileupload fileupload-new' style='width: 250px;' data-provides='fileupload'><input type='hidden' value='' name=''>
          <div class='fileupload-preview thumbnail' style='width: 390px; height: 250px; '></div>
          <div>
         <span class='btn btn-file btn-success'><span class='fileupload-new'>Select image</span>
         <span class='fileupload-exists'>Change</span><input type='file' name=''></span>
      <button name='changepic' value='Save' class='btn btn-danger fileupload-exists' id='changeSitepic' onclick=\"alert('hi');\">Save</button>
       </div>
       </div>
       </form>";

this is the line which causing problem. it works for direct alert() method

<button name='changepic' value='Save' class='btn btn-danger fileupload-exists' id='changeSitepic' onclick=\"alert('hi');\">Save</button>

but when i call it through other javascript function, then this won't work.

<button name='changepic' value='Save' class='btn btn-danger fileupload-exists' id='changeSitepic' onclick=\"changeSitepic();\">Save</button>

here is the javascript code.

<script type="text/javascript">

function changeSitepic(){

     alert('hi');

        }

</script>

I unable to find where i'm doing wrong. please help.

What if you inspect your code with f.ex. F12 in a browser? How does it look there in source? Maybe are there any errors in log? — Karol Gasienica
– Karol Gasienica, Commented Nov 2, 2016 at 13:43

Azeez Kallayi · Accepted Answer · 2016-11-02 13:44:11Z

3

I think your attribute 'id' and function name are same. Please change the 'ID' and try. Change your button like this and try. It may help you

 <button name='changepic' value='Save' class='btn btn-danger fileupload-exists' id='changeSitepic_id' onclick="return changeSitepic()">Save</button>

answered Nov 2, 2016 at 13:44

Azeez Kallayi

2,6421 gold badge17 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Harun Eggleton · Accepted Answer · 2016-11-02 13:44:36Z

2

also there is no need to use double quotes and escape them. just use single quotes.

onclick='javascript:changeSitepic()'

answered Nov 2, 2016 at 13:44

Harun Eggleton

434 bronze badges

Comments

Neo · Accepted Answer · 2016-11-02 13:41:34Z

0

try this in your onclick

onclick=\"javascript:alert('hi');\"

answered Nov 2, 2016 at 13:41

Neo

3,4478 gold badges37 silver badges46 bronze badges

2 Comments

Karol Gasienica Over a year ago

He already tried that, and I think in alert() will be some function he wants to run onclick.

brk Over a year ago

It is not calling changeSitepic

Collectives™ on Stack Overflow

Button onclick event is not calling javascript function in php

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related