Trouble adding onclick events in JavaScript

Question

Every time I try to add an onclick event to a newly created button, the event seems to get triggered before the button is even pressed. Here is how I've been trying to go about it:

var que = document.createElement("BUTTON");
var text = document.createTextNode("Question1");
que.appendChild(text);
document.body.appendChild(que);
que.setAttribute("onclick", function1());

Each time function1() is run before I even have a chance to press the button. Does anyone have any ideas of why?

Grigoryants Artem · Accepted Answer · 2016-12-05 06:41:20Z

2

Try this:

que.setAttribute("onclick",function() {function1();})

or this:

que.onclick = function() {function1();}

answered Dec 5, 2016 at 6:41

Grigoryants Artem

1,6612 gold badges19 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

yadhu · Accepted Answer · 2016-12-05 06:45:56Z

1

It should be que.setAttribute("onclick", "function1()");

See fiddle: https://jsfiddle.net/free_soul/L5s1x1nz/

answered Dec 5, 2016 at 6:45

yadhu

15.6k7 gold badges34 silver badges49 bronze badges

Collectives™ on Stack Overflow

Trouble adding onclick events in JavaScript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related