sending multiple values through javascript

Question

The aim of my code is to send through two values, the primary key for delete qry purposes and second value for the user confirmation window, i.e. You are about to delete the record with the registration no: E12345.

On hover of the delete button, both values are showing as should be (as shown in image below), but the delete button isnt responding, so i assume its the script section that isnt functioning right, as im unsure how to call both vals, im sure its simple but i have very basic knowledge of javascript..

The code worked as expected before i tried implementing the double value through js, originally only had 'uid'

You need to surround the data you're passing to delete_user with quotes. — bejado
– bejado, Commented Feb 14, 2017 at 20:39

dana · Accepted Answer · 2017-02-15 00:37:39Z

3

You should pass 2 parameters to your JS function.

Also, the reg parameter looks to be a string a should be quoted.

JS:

function delete_user(uid, reg) {
    if (confirm('Please confirm whether to delete the vehicle record with the Registration Number: ' + reg)) {
        window.location.href = '../php/clerk-delete.php?id=' + uid; 
    }
}

PHP:

echo '<a href="javascript:delete_user('.$get_info['VehicleId']. ','.htmlentities(json_encode($get_info['VehicleRegNo'])).')">&nbsp;Delete&nbsp;</a>'

edited Feb 15, 2017 at 0:37

answered Feb 14, 2017 at 20:44

dana

18.3k7 gold badges71 silver badges91 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

sanitizer Over a year ago

thanks for the above, i did copy & paste the code, tried both the php & the edit of xss injection, but both showed the same result, instead of coming out as in the image i originally posted, it now shows as 'javascript:delete_user(1,' so i assume its something to do with the quotes? and yes your correct the reg parameter is a string.

sanitizer Over a year ago

what if i call the var's like this: $id = $get_info["VehicleId"]; $reg = $get_info["VehicleRegNo"]; ... would this be easier to call in js?

dana Over a year ago

@CS88 - You are right... I wrapped the output of json_encode with a call to htmlentities which should take care of escaping quote (") character.

sanitizer Over a year ago

Dana, you solved it! The code above worked without a hitch, thank you very much!

D.M. · Accepted Answer · 2017-02-14 20:45:39Z

0

if you just change the + with , it works:

function delete_user(uid,reg) {
  if (confirm('Please confirm whether to delete the vehicle record with the       Registration Number: ' + reg)){
  window.location.href = '../php/clerk-delete.php?id=' + uid; 
  }
}

and then

echo '<a href="javascript:delete_user('.$get_info['VehicleId']. ','.$get_info['VehicleRegNo']. ')">&nbspDelete&nbsp</a>'

answered Feb 14, 2017 at 20:45

D.M.

71 bronze badge

3 Comments

sanitizer Over a year ago

Thanks D.M for the suggestion, i did copy & paste, and the result was the same, the delete button isnt responding when clicked, the values are being shown in the bottom left of my screennlike the image i attached in the post

D.M. Over a year ago

i think you are parsing variables in the function instead of strings so if you do this echo '<a href="javascript:delete_user("'.$get_info['VehicleId']. '","'.$get_info['VehicleRegNo']. '")">&nbspDelete&nbsp</a>' is gonna work

sanitizer Over a year ago

Created an error stating that the webpage is unable to handle the request, " & ' creating a problem somewhere

Collectives™ on Stack Overflow

sending multiple values through javascript

2 Answers 2

4 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related