Java getter methods returning null instead of the string

Question

When I call getName from MyServ class, I get null, but when I call them locally from DBClass they return strings. anyone know what I'm doing wrong?

package DB;

import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.ResultSet;
import java.sql.Statement;

public class DBClass{

    private Statement stmt;
    private Connection conn;
    private ResultSet result;
    public String name, surname;

    public DBClass(){
    }

    public Connection dbConnect(final String db_connect_string,
        final String db_userid,
        final String db_password){

        try{
            DriverManager.registerDriver(new oracle.jdbc.OracleDriver());

            conn =
                DriverManager.getConnection(db_connect_string, db_userid,
                    db_password);

            stmt = conn.createStatement();
            result = stmt.executeQuery("Select * from .....etc");

            if(result.next()){
                name = result.getString(1).toString();
                surname = result.getString(2).toString();
            }
            return conn;

        } catch(final Exception e){
            e.printStackTrace();

            return null;
        }
    }

    public String getName(){
        return name;
    }

    public String getSurname(){
        return surname;
    }

}




package DB;

import java.io.IOException;
import java.sql.Connection;

import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

/**
 * Servlet implementation class MyServ
 */
public class MyServ extends HttpServlet{

    private static final long serialVersionUID = 1L;
    private final DBClass dbclass;
    private final String name, surname;

    private final Connection conn;

    public MyServ(){

        dbclass = new DBClass();
        final DBClass db = new DBClass();

        conn =
            db.dbConnect("jdbc:oracle:thin:@elanweb:1510:xxxxx", "xxxxx",
                "xxxxxx");

        name = dbclass.getName();
        surname = dbclass.getSurname();
    }

    @Override
    protected void doGet(final HttpServletRequest request,
        final HttpServletResponse response) throws ServletException,
        IOException{

    }

    @Override
    protected void doPost(final HttpServletRequest request,
        final HttpServletResponse response) throws ServletException,
        IOException{

        System.out.println("MyServer -- " + name + " " + surname);
        response.sendRedirect("http://localhost:8080/DWP/");

    }
}

Because you're calling 'doConnect' on 'db' but not 'dbclass' inside the MyServ constructor? — ptomli
– ptomli, Commented Nov 26, 2010 at 10:22

karim79 · Accepted Answer · 2010-11-26 10:21:21Z

4

Surely you mean:

name = db.getName();

instead of:

name = dbclass.getName();

You seem to be referencing the wrong variable within the constructor, the one without an open connection (dbclass).

answered Nov 26, 2010 at 10:21

karim79

343k67 gold badges420 silver badges409 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Andrzej Doyle · Accepted Answer · 2010-11-26 10:24:09Z

1

Simply because the value is null (which is a String, kind of).

Look at the relevant bits of the code. In your MyServ constructor, you do:

dbclass = new DBClass();

According to the DBClass constructor, this initialises all fields to default values (which for a String is null).

Then you don't use this variable again until you call:

dbclass.getName();

which correctly goes and looks up the name variable - which is null, because it was implicitly assigned null when the object was constructed - and returns this to you.

Perhaps a better question is, what did you expect it to return, and why?

answered Nov 26, 2010 at 10:24

Andrzej Doyle

104k33 gold badges191 silver badges231 bronze badges

Collectives™ on Stack Overflow

Java getter methods returning null instead of the string

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related