JavaScript loop through to check duplicate value

Question

I am having troubles trying to check if the date exists in the array.

 for(var i = 0; i< crisislist.length; i++){
        hazecounter = 1;
        if(crisislist[i].category == 1){
            if(crisislist[i].date != crisislist[i+1].date) {
                hazelabel.push(crisislist[i].date);
            }else{
                hazecounter++; 
            }
            hazedata.push(hazecounter);
        }
 }

The sample data for the date is:

["01-02-2017", "22-03-2017", "22-03-2017", "07-08-2017"]

And the expected output for hazelabel, hazedata should be:

hazelabel: ["01-02-2017", "22-03-2017", "07-08-2017"] hazedata: [1,2,1]

With the code above, when I check until the last element in the array and trying to make a comparison, it throw me an error message:

Uncaught TypeError: Cannot read property 'date' of undefined

I think this is because when I reach the last element of array, and I try to find crisislist[I+1].date, it could not found and thus the error message.

Any idea how to fix this? Thanks in advance!

Can't you just check if crisislist[i] + 1 is not undefined before accessing the date property? — Teemoh
– Teemoh, Commented Apr 1, 2017 at 17:54
you can write it simply like this stackoverflow.com/questions/40418507/…. jsfiddle demo jsfiddle.net/u6u80zsa — Sankara
– Sankara, Commented Apr 1, 2017 at 18:17

Bergi · Accepted Answer · 2017-04-01 18:00:11Z

0

You must access crisislist[i+1].date only when i doesn't point to the last element.

Also notice that to get the desired result, you need to move the hazedata.push inside the if block and put the initialisation of hazecounter in front of the loop.

var hazecounter = 1;
for (var i = 0; i< crisislist.length; i++) {
    if (crisislist[i].category == 1) {
        if (i == crisislist.length-1 || crisislist[i].date != crisislist[i+1].date) {
            hazelabel.push(crisislist[i].date);
            hazedata.push(hazecounter);
            hazeCounter = 1;
        } else {
            hazecounter++; 
        }
    }
}

edited Apr 1, 2017 at 18:00

answered Apr 1, 2017 at 17:57

Bergi

671k162 gold badges1k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user7691120 Over a year ago

Thanks it works! I was thinking how to check for the last element.

jas7457 · Accepted Answer · 2017-04-01 17:56:49Z

0

Your if statement is going to be a problem.

if(crisislist[i].date != crisislist[i+1].date) {

You are accessing crisislist[i+1] in a loop that goes to < crisislist.length. That means that if you have an array of size 4, your loop will go until i = 3, but you are accessing i+1 from the array (crisislist[4]), which will be undefined.

Try changing your for loop to go to crisis.length-1

answered Apr 1, 2017 at 17:56

jas7457

1,80217 silver badges22 bronze badges

Comments

Vivek Doshi · Accepted Answer · 2017-04-01 18:01:37Z

0

You just need to check till second last :

for(var i = 0; i< (crisislist.length-1); i++){
        hazecounter = 1;
        if(crisislist[i].category == 1){
            if(crisislist[i].date != crisislist[i+1].date) {
                hazelabel.push(crisislist[i].date);
                if (crisislist.length-2 == i)
                {
                    hazelabel.push(crisislist[i+1].date);
                }
            }else{
                hazecounter++; 
            }
            hazedata.push(hazecounter);
        }
 }

edited Apr 1, 2017 at 18:01

answered Apr 1, 2017 at 17:54

Vivek Doshi

58.8k12 gold badges120 silver badges126 bronze badges

3 Comments

Bergi Over a year ago

But that would ignore the last one?

Vivek Doshi Over a year ago

just try out it will be compared with second last so it will not

Bergi Over a year ago

compared, yes, but the last item is not looked at separately.

5ka · Accepted Answer · 2017-04-01 18:11:13Z

Check that code. If you have any questions, add a comment :) In my solution dates dont have to be sorted.

  </head>

<BODY>
<script>

function Something(date)
{
    this.date = date;
    this.category = 1;
}

var crisislist = [];
var hazelabel = [];
var hazedata = [];
crisislist[0] = new Something("01-02-2017");
crisislist[1] = new Something("22-03-2017");
crisislist[2] = new Something("22-03-2017");
crisislist[3] = new Something("07-08-2017");




 for(var i = 0; i< crisislist.length; i++){
    if(crisislist[i].category == 1)
    {
     if(!hazelabel[crisislist[i].date])
     {
         hazelabel[crisislist[i].date] = crisislist[i].date;
         hazedata[crisislist[i].date] = 1;
     }
     else
     {
         hazedata[crisislist[i].date]++;
     }
    }
 }

for(var key  in hazelabel)
{
console.log(hazelabel[key]);
console.log(hazedata[key]);  
}

</script>
</BODY>
</HTML>

Collectives™ on Stack Overflow

JavaScript loop through to check duplicate value

4 Answers 4

1 Comment

Comments

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related