executing python script through nodejs

Question

I am trying to execute this piece of node js code which execute a python script. Through this code works fine. but the response "running" and "finished" are displayed on front end immediately. "finshed" has to be displayed once the execution of python scripts gets completed.

app.post('/execute', function(request, response){
    response.write("running");
    console.log("executing")
    var pyshell = new PythonShell('./python_codes/test.py')
    pyshell.on('message', function (message) {console.log(message);});
    pyshell.end(function (err) {if (err){throw err;};console.log('finished');});
    response.write("finished");
    response.end();
});

PythonShell uses child_process.spawn, which is asynchronous - you're saying here "Run this python thing, and tell me when it's done by using the callback I've given you with .end, and while you're doing that I will carry on with my own stuff". I suspect you'll need to either wait for pyshell.terminated to show the right value, or pass the response into the .end callback — Simon Fraser
– Simon Fraser, Commented Apr 19, 2017 at 11:13
@SimonFraser The full code isn't shown so it's unknown if the HTTP library supports that - it's possible (and even likely) that once the app.post callback is done running response.end() will be called implicitly. — Fredrick Brennan
– Fredrick Brennan, Commented Apr 19, 2017 at 11:22
@FredrickBrennan Fair point :) I'm more python than node, so I was trying to work things out looking at PythonShell — Simon Fraser
– Simon Fraser, Commented Apr 19, 2017 at 11:28

Ezzat · Accepted Answer · 2017-04-19 12:19:55Z

1

You should add your response inside the callback function

app.post('/execute', function(request, response){

  response.setHeader('Connection', 'Transfer-Encoding'); 
  response.setHeader('Content-Type', 'text/html; charset=utf-8');

  response.write("running");
  console.log("executing")
  var pyshell = new PythonShell('./python_codes/test.py')
  pyshell.on('message', function (message) {console.log(message);});
  pyshell.end(function (err) {
    if (err){
      throw err;
    };
    console.log('finished');
    response.write("finished");
    response.end();
  });
});

edited Apr 19, 2017 at 12:19

answered Apr 19, 2017 at 11:21

Ezzat

9016 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

nishant kumar Over a year ago

I tried but with approach it is also not sending the "running" msg. all the msg are sent after execution test.py

Ezzat Over a year ago

Add response.setHeader('Connection', 'Transfer-Encoding'); response.setHeader('Content-Type', 'text/html; charset=utf-8'); To allow browser to show the content immediately.

Community · Accepted Answer · 2017-05-23 12:09:39Z

It happens because the PythonShell class is asynchronous. What your code is doing is creating a PythonShell object, storing it in variable pyshell, and then adding a few events to the pyshell object. It then directly continues to write "finished".

Because writing "finished" is not part of the callback for the end() function, it happens right away. I see at least three things you can do:

If the HTTP library you are using supports it, just add the response.write("finished"); response.end(); code to the pyshell.end callback.
Call Python using a library which supports pausing the current execution thread (or use execSync). This is bad practice, because it defeats the purpose of using a concurrent framework like node.js, but would work.
Use WebSockets (or socket.io, which works even if WebSockets aren't available, such as through CloudFlare) to transmit the "finished" message.

Collectives™ on Stack Overflow

executing python script through nodejs

2 Answers 2

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related