Create programatically UITableViewController with user defined cell

Question

I have created UITableViewController programatically in viewDidLoad():

resultsController = UITableViewController(style: UITableViewStyle.plain)
resultsController.tableView.register(MyTableCellTableViewCell.self, forCellReuseIdentifier: "userFoundCell")
resultsController.tableView.dataSource = self
resultsController.tableView.delegate = self

However, when I later do

override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {

   var cell: MyTableCellTableViewCell? = tableView.dequeueReusableCell(withIdentifier: "userFoundCell", for: indexPath) as? MyTableCellTableViewCell

   if (cell == nil){
        cell = MyTableCellTableViewCell(style: UITableViewCellStyle.default, reuseIdentifier: "userFoundCell")
   }

   cell!.lblTmp!.text = "test"
   return cell!
}

cell is never nil, I have tested it

Code crash with:

fatal error: unexpectedly found nil while unwrapping an Optional value on cell!.lblTmp!.text = "test"

My MyTableCellTableViewCell looks like this

class MyTableCellTableViewCell: UITableViewCell {
    @IBOutlet var lblTmp: UILabel!

    override func awakeFromNib() {
        super.awakeFromNib()
    }

    override func setSelected(_ selected: Bool, animated: Bool) {
        super.setSelected(selected, animated: animated)
    }
}

IBoutlet is connected in Interface Builder to GUI elements. The same class is used on another place as well.

@Sulthan it is connected. Or at least in my second table, that is using the same class, but is inited from IB, all is working — Martin Perry
– Martin Perry, Commented May 6, 2017 at 18:42
You said the label is connected but you also said you have no xib file. Since you are not using storyboard either, how exactly are you defining the view for MyTableCellTableViewCell and how exactly are you connecting the label? — Sulthan
– Sulthan, Commented May 6, 2017 at 18:45
You are not using a storyboard though. Your resultsController is not instantiated from a storyboard. — Sulthan
– Sulthan, Commented May 6, 2017 at 18:47
@Sulthan I have combination of both. Something from storyboard, something from code. This is inited from code, on another place from storyboard — Martin Perry
– Martin Perry, Commented May 6, 2017 at 18:49

Balaji Galave · Accepted Answer · 2017-05-06 18:42:26Z

5

If you have your custom tableview cell with xib and class then you should register your cell by following way.

If you have your table view cell xib file name like "MyTableCellTableViewCell" this then replace your line

resultsController.tableView.register(MyTableCellTableViewCell.self, forCellReuseIdentifier: "userFoundCell")

with this line

resultsController.tableView.register(UINib(nibName: "MyTableCellTableViewCell", bundle: nil), forCellReuseIdentifier: "userFoundCell")

answered May 6, 2017 at 18:42

Balaji Galave

1,0766 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Martin Perry Over a year ago

I dont have xib file.

Balaji Galave Over a year ago

then how did you make @IBOutlet var lblTmp: UILabel! this line into Custom table view cell.?

Martin Perry Over a year ago

I have it connected to storyboard

Balaji Galave Over a year ago

then its a prototype cell.

Sulthan Over a year ago

resultsController would have to be instantiated from that storyboard and from that specific controller which contains the prototype cell.

Mike Taverne · Accepted Answer · 2017-05-06 19:00:19Z

1

This pattern of creating cells is wrong:

if (cell == nil){
    cell = MyTableCellTableViewCell(style: UITableViewCellStyle.default, reuseIdentifier: "userFoundCell")
}

You should do this instead (force cast using ! is appropriate here in my opinion):

let cell = tableView.dequeueReusableCell(withIdentifier: "userFoundCell", for: indexPath) as! MyTableCellTableViewCell

If this line crashes, then it means your custom cell was not registered properly. This will help you to isolate the problem.

answered May 6, 2017 at 19:00

Mike Taverne

9,3804 gold badges44 silver badges59 bronze badges

Comments

Scott Thompson · Accepted Answer · 2017-05-06 19:00:28Z

0

While the cell is not nil, you don't seem to be checking whether or not lblTmp is nil. If lblTmp is nil then trying to set cell!.lblTmp!.text = "test" will crash with unexpectedly found nil while unwrapping an Optional value. How are you setting lblTmp to a value?

answered May 6, 2017 at 19:00

Scott Thompson

23.8k4 gold badges36 silver badges39 bronze badges

Comments

Shaheen M Basheer · Accepted Answer · 2017-05-06 21:14:16Z

0

You dont have to do unwrapping cell!.lblTmp!.text = "test" after declaring an implicitily unwrapped optional @IBOutlet var lblTmp: UILabel!

Use cell!.lblTmp.text = "test" instead.

answered May 6, 2017 at 21:14

Shaheen M Basheer

1,0106 silver badges11 bronze badges

Collectives™ on Stack Overflow

Create programatically UITableViewController with user defined cell

4 Answers 4

5 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

5 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related