jQuery AJAX call PHP Class function

Question

I wrote an user action analysis but I can't execute my insert into statement. I tried all suggestion on stack can't but figure out my mistake, I don't even get an error: it is running through without executing the statement. I have also an connection php - this works fine so the fault is not there. I would like to insert the action var later but at first I have to call the function. So whats wrong with my request or php function?

jQuery

$( document ).ready(function() {
  var action = '';
  document.addEventListener('click', function(e) {
    e = e || window.event;
    e = e.target || e.srcElement;
    if (e.nodeName === 'SECTION') {
      action = e.id;
      updateAction();
    }
  }, false);

  function updateAction() {
    $.ajax({
      type: "POST",
      url: '../actions/userAction.php',
      data: {action: 'test'},
      success: function(){
        console.log(action);
      }
    });
  }
});

PHP

<?php
class userAction
{
  /* User Action */
  public function updateAction(){
    if(isset($_POST['action']) && !empty($_POST['action'])) {
      $db = getDB();
      $st = $db->prepare("INSERT INTO user_analysis (action) VALUES ('bla') where userID = 1945");
      $st->execute();
      $db = null;
      $_SESSION['uid']=$uid;
      return true;
    }    else
    {
      return false;
    }
  }
}
?>

First of all check whether you are entering updateAction() in this function? if entering then check you are getting value in post or not. And also query is wrong — Pankaj Makwana
– Pankaj Makwana, Commented Jun 16, 2017 at 7:14
INSERT command cannot have WHERE clause. IF you are updating a record, use UPDATE — Milan Chheda
– Milan Chheda, Commented Jun 16, 2017 at 7:15
Pankaj yeah this is the fault i think i can't enter the function and getting an syntax error in the comment here my whole code link — mY777
– mY777, Commented Jun 16, 2017 at 7:19

Sebastian Kaczmarek · Accepted Answer · 2017-06-16 07:23:51Z

Where do you call updateAction() method? I assume you don't. Then why do you expect that it will execute? You have at least 3 ways to deal with it.

1. Make the method static and call it without instantiating a class

If you don't have any reason to construct an object of your class then you can call your method without doing it. Just add this line of code after your class definition:

userAction::updateAction()

This way you call the method which handles your POST request.

2. Instantiate your class and then call your method

The same story as above. The difference here is to construct an object first:

$ua = new userAction();
$ua->updateAction();

3. (the easiest) Get rid of the class and method

As the title suggest. Remove whole code of a class and leave only the body of your method. Like this:

if(isset($_POST['action']) && !empty($_POST['action'])) {
   $db = getDB();
   $st = $db->prepare("INSERT INTO user_analysis (action) VALUES ('bla') where userID = 1945");
   $st->execute();
   $db = null;
   $_SESSION['uid']=$uid;

   return true;
} else {
   return false;
}

This should be the whole content of your file: a condition.

BTW
1. Your query is not valid. If you want to UPDATE a row you need to use UPDATE statement, not INSERT
2. I would suggest you call your class UserAction (uppercase). Just to make it standardised and more intuitive
3. Why do you mix jQuery with VanillaJS? You use jQuery and bind an event using clear JS. Make it semantic and decide if you use jQuery or not.
jQuery way:

var action = '';
$(document).on('click', function(e) {
  e = e || window.event;
  e = e.target || e.srcElement;
  if (e.nodeName === 'SECTION') {
    action = e.id;
    updateAction();
  }
});

That's all. I hope I could help

Milan Chheda · Accepted Answer · 2017-06-16 07:16:42Z

0

You need to use UPDATE instead of INSERT. Try this below code:

UPDATE user_analysis SET action = 'bla' WHERE id = 1945

answered Jun 16, 2017 at 7:16

Milan Chheda

8,2593 gold badges23 silver badges35 bronze badges

1 Comment

mY777 Over a year ago

unfortunately no , problem is don't get any error so if i can debug it but i think it is an syntax error , the ajax call is right or ?

Bilal Ahmed · Accepted Answer · 2017-06-16 08:47:32Z

0

if(isset($_POST['action']) && !empty($_POST['action'])) {     
  echo $_POST['action'];
}

echo the value of $_POST['action'] inside your if loop...If not getting try to change the - type: "POST", to "GET",

edited Jun 16, 2017 at 8:47

Bilal Ahmed

4,0663 gold badges25 silver badges42 bronze badges

answered Jun 16, 2017 at 7:10

Renjitha22

2132 gold badges7 silver badges22 bronze badges

2 Comments

Renjitha22 Over a year ago

try to solve the syntax error, and change the type as GET

Sebastian Kaczmarek Over a year ago

I assume you forgot about ;

Collectives™ on Stack Overflow

jQuery AJAX call PHP Class function

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related