C# constructor to call constructor after executing code

Question

I've seen answers on constructor chaining but they don't apply for my problem.

I have a the following constructor that requires a couple of parameters:

public SerilogHelper(string conString, int minLevel)
    {
        var levelSwitch = new LoggingLevelSwitch();
        levelSwitch.MinimumLevel = (Serilog.Events.LogEventLevel)(Convert.ToInt32(minLevel));

        _logger = new LoggerConfiguration()
            .MinimumLevel.ControlledBy(levelSwitch)
            .WriteTo.MSSqlServer(connectionString: conString, 
                                 tableName: "Logs", 
                                 autoCreateSqlTable: true)
            .CreateLogger();
    }

One particular client of this constructor won't have the values required for the parameters so I'd like to be able to call this simple constructor which would get the required values then call the 1st constructor:

public SerilogHelper()
    {
        string minLevel = SSOSettingsFileManager.SSOSettingsFileReader.ReadString(
          "LCC.Common", "serilog.level");
        string conString = SSOSettingsFileManager.SSOSettingsFileReader.ReadString(
          "LCC.Common", "serilog.connectionstring");

        SerilogHelper(conString, minLevel);
    }

Problem is, I get a red squiggly on the call to the 2nd constructor with the message SerilogHelper is a 'type' but used like a 'variable'

Possible duplicate of C# constructors overloading

Liam
– Liam

2017-06-20 10:31:02 +00:00
Commented Jun 20, 2017 at 10:31 — Liam
– Liam, Commented Jun 20, 2017 at 10:31

mrogal.ski · Accepted Answer · 2017-06-20 10:39:03Z

Why not just simply add these parameters?

// this assumes that SSOSettingsFileManager is static class
// this will automatically call these methods before passing 
// values to another ( non parameterless ) constructor
public SerilogHelper()
    : this ( 
        SSOSettingsFileManager.SSOSettingsFileReader.ReadString(
            "LCC.Common", "serilog.connectionstring"
        ),
        SSOSettingsFileManager.SSOSettingsFileReader.ReadString(
            "LCC.Common", "serilog.level"
        )
    )
{

}

// This will be called from default ( parameterless )
// constructor with values retrieved from methods
// called in previous constructor.
public SerilogHelper(string conString, int minLevel)
{
        var levelSwitch = new LoggingLevelSwitch();
        levelSwitch.MinimumLevel = (Serilog.Events.LogEventLevel)(Convert.ToInt32(minLevel));

        _logger = new LoggerConfiguration()
            .MinimumLevel.ControlledBy(levelSwitch)
            .WriteTo.MSSqlServer(connectionString: conString, 
                                 tableName: "Logs", 
                                 autoCreateSqlTable: true)
            .CreateLogger();
}

Test online

Patrick Hofman · Accepted Answer · 2017-06-20 10:26:46Z

You cannot do that. The best option you have it so move the initialization code to a separate method which you can call from both the constructors. That is allowed.

public SerilogHelper()
{
    string minLevel = SSOSettingsFileManager.SSOSettingsFileReader.ReadString(
      "LCC.Common", "serilog.level");
    string conString = SSOSettingsFileManager.SSOSettingsFileReader.ReadString(
      "LCC.Common", "serilog.connectionstring");

    this.Initialize(conString, minLevel);
}

public SerilogHelper(string conString, int minLevel)
{
    this.Initialize(conString, minLevel);
}

protected void Initialize(string conString, int minLevel)
{
    var levelSwitch = new LoggingLevelSwitch();
    levelSwitch.MinimumLevel = (Serilog.Events.LogEventLevel)(Convert.ToInt32(minLevel));

    _logger = new LoggerConfiguration()
        .MinimumLevel.ControlledBy(levelSwitch)
        .WriteTo.MSSqlServer(connectionString: conString, 
                             tableName: "Logs", 
                             autoCreateSqlTable: true)
        .CreateLogger();
}

Dmitrii Bychenko · Accepted Answer · 2017-06-20 10:33:14Z

2

I suggest using default values:

public SerilogHelper(string conString = null, int minLevel = -1)
{
    if (minLevel == -1)
      minLevel = SSOSettingsFileManager.SSOSettingsFileReader.ReadString(
      "LCC.Common", "serilog.level");

    if (conString == null)
      conString = SSOSettingsFileManager.SSOSettingsFileReader.ReadString(
      "LCC.Common", "serilog.connectionstring");

    var levelSwitch = new LoggingLevelSwitch();
    levelSwitch.MinimumLevel = (Serilog.Events.LogEventLevel)(Convert.ToInt32(minLevel));

    _logger = new LoggerConfiguration()
        .MinimumLevel.ControlledBy(levelSwitch)
        .WriteTo.MSSqlServer(connectionString: conString, 
                             tableName: "Logs", 
                             autoCreateSqlTable: true)
        .CreateLogger();
}

....

SerilogHelper myInstance = new SerilogHelper();

Edit: I've assumed that minLevel = -1 being invalid can be used a as default value, if it's not the case (any minLevel values are allowed) int? is a possible way out:

public SerilogHelper(string conString = null, int? minLevel = null)
{
    if (!minLevel.HasValue)
      minLevel = SSOSettingsFileManager.SSOSettingsFileReader.ReadString(
      "LCC.Common", "serilog.level");

    if (conString == null)
      conString = SSOSettingsFileManager.SSOSettingsFileReader.ReadString(
      "LCC.Common", "serilog.connectionstring");

    var levelSwitch = new LoggingLevelSwitch();
    levelSwitch.MinimumLevel = (Serilog.Events.LogEventLevel)(Convert.ToInt32(minLevel));

    _logger = new LoggerConfiguration()
        .MinimumLevel.ControlledBy(levelSwitch)
        .WriteTo.MSSqlServer(connectionString: conString, 
                             tableName: "Logs", 
                             autoCreateSqlTable: true)
        .CreateLogger();
}

edited Jun 20, 2017 at 10:33

answered Jun 20, 2017 at 10:28

Dmitrii Bychenko

188k20 gold badges178 silver badges231 bronze badges

4 Comments

Patrick Hofman Over a year ago

That can only be used when conString == null and minLevel == -1 are not valid values.

Dmitrii Bychenko Over a year ago

@Patrick Hofman: quite right; if arbitrary minLevel is allowed then int? minLevel = null is a possible way out.

user310988 Over a year ago

Optional Parameters have quite a few gotchas. One is "ambiguity" ... given "public Test() { Console.WriteLine("Default"); }" and "public Test(int i = 0) { Console.WriteLine("Optional"); }", what does "new Test()" call? Another is the default value gets "Baked in" to the calling code. So, if you change a default value, you have to recompile all calling code. e.g. If ProjectA has a constructor with optional parameters, and ProjectB calls that constructor, if you recompile ProjectA, but NOT ProjectB then ProjectB will still call the constructor with the old default value.

Dmitrii Bychenko Over a year ago

@AndyJ: You are quite right, optional values should be used with care; but here we are not going to be trapped with either antipattern 1 (all we want is possibility not to provide connection string and level) or antipettern 2 (we have no magic values which we'll want to change in future, but null and -1 (null if any level is allowed))

Collectives™ on Stack Overflow

C# constructor to call constructor after executing code

3 Answers 3

Comments

Comments

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related