jQuery function called in a .bind click handler is running on document ready

Question

I defined a simple function and attached a "click" handler to a link using .bind().

The function is not running on click - rather, it is running on document ready. Not sure why this is happening.

I am using jQuery 1.3.2.

HTML

<a href="#">click me</a>

jQuery

$(document).ready(function(){
  leftTurn = function($message){
    alert ($message);        
  };

  $('a').bind('click', leftTurn('hello'));
});

The code is also here in a JSFiddle

+1 for well formed question and jsfiddle link. @gov's answer taught me something too! — jyoseph
– jyoseph, Commented Dec 17, 2010 at 17:32

Soviut · Accepted Answer · 2010-12-17 17:31:59Z

5

You're calling the function when you include () at the end. The .bind() function expects a reference to the function itself, not the called result.

leftTurn = function(){
        alert ('hello');        
    };

$(document).ready(function(){
    $('a').bind('click', leftTurn);
});

edited Dec 17, 2010 at 17:31

Soviut

92.2k53 gold badges210 silver badges285 bronze badges

answered Dec 17, 2010 at 17:28

kobe

15.9k15 gold badges67 silver badges93 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Mike Eng Over a year ago

Nice. Works in a simple function with no arguments, but how do you pass an argument to the function? I edited the code in the question and the jsfiddle

Matthias Over a year ago

I would probably write it as jyoseph did, but alternatively you can pass data into the handler like so: api.jquery.com/on/#passing-data

jyoseph · Accepted Answer · 2010-12-17 17:26:43Z

3

I think you may want to use the callback/handler of bind:

$('a').bind('click', function(){
    leftTurn();    
});

Demo

From the docs:

 .bind( eventType, [ eventData ], handler(eventObject) )

answered Dec 17, 2010 at 17:26

jyoseph

5,4659 gold badges47 silver badges66 bronze badges

1 Comment

jwheron Over a year ago

Yep -- I made this mistake a lot early on working with jQuery. Wrapping a function call inside a function is still a little odd to me.

Collectives™ on Stack Overflow

jQuery function called in a .bind click handler is running on document ready

2 Answers 2

2 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related