ForEach returns empty array - Node.js

Question

I am using node async feature. I am forming new array by iterating the existing array. I would like to return the new array after the call back is finished. res.json(arr) responds empty array. Help me identifying the problem.

 getAllUsers(function(users) {
       var arr = [];
        async.forEach(users, function(user, callback) {
          var id = user._id;
          getAllCustomers(id, function(customers) {
            var count = customers.length;
            user.customers = count;
            arr.push(user);
          });
          callback();

        }, function(err) {
          console.log('iterating done');
          res.json(arr); // returns [], empty array
        });
      });

How are you calling this function

Shubham Khatri
– Shubham Khatri

2017-07-12 05:56:24 +00:00
Commented Jul 12, 2017 at 5:56 — Shubham Khatri
– Shubham Khatri, Commented Jul 12, 2017 at 5:56

Tolsee · Accepted Answer · 2017-07-12 06:00:56Z

1

Your problem is, even if the getAllCustomers is not finished your callback is called. Please try the following:

getAllUsers(function(users) {
   var arr = [];
    async.each(users, function(user, callback) {
      var id = user._id;
      getAllCustomers(id, function(customers) {
        var count = customers.length;
        user.customers = count;
        arr.push(user);
        callback();
      });


    }, function(err) {
      console.log('iterating done');
      res.json(arr); // returns [], empty array
    });
  });

answered Jul 12, 2017 at 6:00

Tolsee

1,71516 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ashish maurya · Accepted Answer · 2017-07-12 06:07:23Z

1

you should use callback inside getAllCustomers

getAllUsers(function(users) {
       var arr = [];
        async.forEach(users, function(user, callback) {
          var id = user._id;
          getAllCustomers(id, function(customers) {
            var count = customers.length;
            user.customers = count;
            arr.push(user);
          callback();

          });


        }, function(err) {
          console.log('iterating done');
          res.json(arr); // returns [], empty array
        });
      });

answered Jul 12, 2017 at 6:07

ashish maurya

416 bronze badges

Collectives™ on Stack Overflow

ForEach returns empty array - Node.js

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related