JS How to push integers from for loop into array

Question

var period  = document.getElementById('period').value;
        var col = element.id.split('time')[1];
        var ValueArr=[];
        for(var x= 0;x < period; x++){
            var taskValue = document.getElementById('taskDone'+x).value;
            for(var p= 0;p < taskValue; p++){
                var ValueB = document.getElementById(col+"_"+taskValue).value;
                console.log(ValueB);
                ValueArr.push(ValueB);
                //var newValue = ValueArr.sort(function (a, b) {  return a - b;  });
            }
        }
        alert(newValue);

So I have this in a function and I want to push ValueB into ValueArr. For ValueB it will be with unspecified length of numbers and with unspecified numbers but when I try I get This:https://i.sstatic.net/QqVpm.jpg

Ankit Agarwal · Accepted Answer · 2017-09-11 12:01:30Z

3

You have done mistake in alert. It should be alert(ValueArr); instead of alert(newValue); . That is why you are getting that error Reference error: newValue is not defined. Also you need unique elements in ValueArr, so use this code

var newValue = ValueArr.filter(function(itm, i, a) {
    return i == a.indexOf(itm);
});

Fixed code:

var period  = document.getElementById('period').value;
var col = element.id.split('time')[1];
var ValueArr=[];
for(var x= 0;x < period; x++){
    var taskValue = document.getElementById('taskDone'+x).value;
    for(var p= 0;p < taskValue; p++){
        var ValueB = document.getElementById(col+"_"+taskValue).value;
        console.log(ValueB);
        ValueArr.push(ValueB);
        var newValue = ValueArr.filter(function(itm, i, a) {
             return i == a.indexOf(itm);
        });
        //var newValue = ValueArr.sort(function (a, b) {  return a - b;  });
    }
}
alert(ValueArr);

edited Sep 11, 2017 at 12:01

answered Sep 11, 2017 at 11:44

Ankit Agarwal

30.8k5 gold badges41 silver badges63 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Яни Георгиев Over a year ago

no, I am trying to fix the push if you see in the picture it prints what is in ValueArr after the push and I only want to have 1,2,3

Collectives™ on Stack Overflow

JS How to push integers from for loop into array

1 Answer 1

Fixed code:

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Fixed code:

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related