PHP URL redirect error

Question

I am trying to write a simple PHP URL redirect script but it's not working.

    <?php

    if (isset($_GET['link'])) {
header('Location: $_GET['link']');    
    }else{
        echo 'invalid link';
    }
?>

If I access the script as http://www.example.com/redirect.php, then it goes into else loop and I get output as 'invalid link' in the browser.

But if I access it as https://www.example.com/redirect.php?link=https://www.google.com then I get HTTP error 500. Ideally page should be redirected to https://www.google.com

I am new to PHP and unable to figure it out, any help please?

just saw php error log "[21-Oct-2017 05:53:48 UTC] PHP Parse error: syntax error, unexpected 'link' (T_STRING), expecting ',' or ')' in redirect.php on line 4" — Pankaj
– Pankaj, Commented Oct 21, 2017 at 6:00

mega6382 · Accepted Answer · 2017-10-21 06:07:42Z

1

try the following:

if (isset($_GET['link'])) {
    header("Location: {$_GET[link]}");    
}else{
    echo 'invalid link';
}

' single quotes cannot escape variables in php you need to use " double quotes for that. And there is not need to enclose the index with quotes when being used inside a string. And as for the {} curly brackets that I am using look into Complex Curly Brackets

Also, as you were doing it with 'Location: $_GET['link']' there was another problem with that, that the string was starting from 'Location: but was ending at $_GET[' because it was closing the single quotes there and was causing an error too.

edited Oct 21, 2017 at 6:07

answered Oct 21, 2017 at 6:01

mega6382

9,39217 gold badges52 silver badges73 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Pankaj Over a year ago

Thanks, it worked. I also noticed it after few mins but you were really quick to answer.

Pankaj Over a year ago

SO requires 10 mins wait before accepting the answer. :)

jvk · Accepted Answer · 2017-10-21 06:20:43Z

1

you are giving invalid string matching string

if (isset($_GET['link'])) {
header('Location:'.$_GET['link']);    
    }else{
        echo 'invalid link';
    }

or this method also works

header("Location: " . $_SERVER['REQUEST_URI']);

see the difference $_GET['link'] and $_SERVER['REQUEST_URI']

what is the difference between $_SERVER['REQUEST_URI'] and $_GET['q']?

edited Oct 21, 2017 at 6:20

answered Oct 21, 2017 at 6:04

jvk

2,1893 gold badges22 silver badges28 bronze badges

3 Comments

Pankaj Over a year ago

Thanks for showing alternative way by using $_SERVER. BTW, which is the better, secure and faster way to go.

mega6382 Over a year ago

Security and speed wise there is no difference as the alternative method only uses another variable. But it will not provide the same result. It will work for https://www.example.com/redirect.php?link=test.php but not for https://www.example.com/redirect.php?link=https://www.google.com

mega6382 Over a year ago

Also, your first method have a syntax error, 'Location:' $_GET['link'] should be 'Location:' . $_GET['link']

Nimesh Vagadiya · Accepted Answer · 2017-10-21 06:51:46Z

1

$url = !empty($_GET['link']) ? $_GET['link'] : '';
if ($url){
    header('Location:' . $url);
    exit;
}else{
    echo 'invalid link';
}

answered Oct 21, 2017 at 6:51

Nimesh Vagadiya

6323 gold badges8 silver badges18 bronze badges

Collectives™ on Stack Overflow

PHP URL redirect error

3 Answers 3

2 Comments

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related